More qflags#171
Merged
Merged
Conversation
…ion in module Qt3DRender
…e in module Qt3DRender
…in module QtChart
…Orientation in module QtChart
…in module QtChart
…anager.TargetAccessMode in module QtNfc
…reManager.ShareMode in module QtNfc
….AccessMethod in module QtNfc
… module QtBluetooth
…ccessConstraint in module QtBluetooth
…ble.RunFlag in module QtMultimedia
… module QtSerialPort
…nal in module QtSerialPort
…lag in module QtWebEngineCore
…ContextMenuData.MediaFlag in module QtWebEngineWidgets
…ontextMenuData.EditFlag in module QtWebEngineWidgets
…g in module QtWebEngineWidgets
…ormWindowInterface.FeatureFlag in module QtDesigner
altendky
reviewed
Dec 27, 2021
Collaborator
altendky
left a comment
altendky
left a comment
There was a problem hiding this comment.
There are a lot of new files. Perhaps they should be grouped by the module they are for?
Comment on lines
+12
to
+14
| for path in TESTS_DIR.glob('*.py'): | ||
| if not path.name.startswith('test_'): | ||
| yield path |
Collaborator
There was a problem hiding this comment.
Suggested change
| for path in TESTS_DIR.glob('*.py'): | |
| if not path.name.startswith('test_'): | |
| yield path | |
| yield from TESTS_DIR.glob('test_*.py') |
Collaborator
Author
There was a problem hiding this comment.
the suggestion changes the code. We want the path not starting with test_
Collaborator
Author
|
Grouping the files could make sense althought it means spending again some time on the generation scripts. If that's OK for you, I would like to commit them asis and update them by grouping them later in 2022. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add QFlag related methods to all modules within PyQt5-stubs. This is to be merged after #153 .