Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] fix: fix support for packaging v20.4 #6808

Merged
merged 1 commit into from
Nov 5, 2022

Commits on Nov 5, 2022

  1. fix: fix support for packaging v20.4

    Poetry v1.2.2 does not work with packaging v20.4
    (which is an allowed version of packaging in the pyproject.toml file).
    
    This is because the `from packaging.utils import NormalizedName` line
    before [packaging v20.5][1]
    only works if `typing.TYPE_CHECKING` is True.
    
    This is not an issue on the `master` branch, since there this
    import is already hidden behind an `if TYPE_CHECKING:` guard.
    However, the v1.2 branch never cherry-picked the appropriate
    commit adding this change.
    
    [1]: pypa/packaging@eca30e0
    
    Fixes: python-poetry@04c5cbf
    aloisklink authored and radoering committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    020ebe5 View commit details
    Browse the repository at this point in the history