Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rmtree failures on Windows (#1031) #1032

Closed
wants to merge 2 commits into from
Closed

Fix rmtree failures on Windows (#1031) #1032

wants to merge 2 commits into from

Commits on Apr 15, 2019

  1. Fix rmtree failures on Windows (python-poetry#1031)

    @Pluckerpluck
    Pluckerpluck committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    3a37693 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Use the CPython method for rmtree 

    Rather than a fixed timeout, use an exponentially increasing timeout.
This results in the ability to more quickly respond without burning CPU cycles. 

Use a maximum 2 second wait, as we simply repeat `rmtree`.
CPython implements their own `_rmtree` allowing for tighter checks.
    @Pluckerpluck
    Pluckerpluck authored May 2, 2019
    Configuration menu
    Copy the full SHA
    bc0a4b8 View commit details
    Browse the repository at this point in the history