Skip to content

poetry add --dev not installing as dev dependency for git dependencies #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GiancarloFusiello opened this issue Feb 12, 2019 · 4 comments

Comments

@GiancarloFusiello
Copy link

GiancarloFusiello commented Feb 12, 2019

Hi @sdispater, poetry is a great tool that has been missing from the Python community for a long time. I wanted to point out this small bug that I hope should be an easy fix.

poetry add libero-schemas --git https://github.com/libero/schemas.git --dev

Installs the dependency and adds it to pyproject.toml:

[tool.poetry.dependencies]
lxml = "^4.3"

[tool.poetry.dev-dependencies]
libero-schemas = {git = "https://github.com/libero/schemas.git"}

However, in poetry.lock it appears to have installed as a main dependency rather than a dev dependency:

[[package]]
category = "main"
description = "Libero data model schemas"
name = "libero-schemas"
optional = false
python-versions = "*"
version = "0.0.1"

[package.source]
reference = "cebfb5fb66b3bd7b820e2cebf50f9cc471d5204c"
type = "git"
url = "https://github.com/libero/schemas.git"
[[package]]
category = "main"
description = "Powerful and Pythonic XML processing library combining libxml2/libxslt with the ElementTree API."
name = "lxml"
optional = false
python-versions = "*"
version = "4.3.0"

Also notice that a blank line is missing after [package.source] in poetry.lock.

Thanks, in advance and keep up the good work.

@nyanpasu64
Copy link

nyanpasu64 commented Mar 28, 2019

I've noticed the same issue, with no response from the developers... Is this related to #599 ?

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@stale
Copy link

stale bot commented Nov 20, 2019

Closing this issue automatically because it has not had any activity since it has been marked as stale. If you think it is still relevant and should be addressed, feel free to open a new one.

@stale stale bot closed this as completed Nov 20, 2019
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants