poetry new silently transforms underscores to dashes

[Gerrit-K]

• Poetry version: 1.7.1

• Python version: 3.9.18

• OS version and name: macOS 14.2.1 (23C71)

• pyproject.toml: none, see repro steps below

• I am on the latest stable Poetry version, installed using a recommended method.

• I have searched the issues of this repo and believe that this is not a duplicate.

• I have consulted the FAQ and blog for any relevant entries or release notes.

• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

Poetry doesn't handle underscores in package names really well. Two examples are:

• poetry new test_package
  • prints Created package test_package in test_package
  • but cat test_package/pyproject.toml actually prints name = "test-package"
• poetry version still prints test-package, even if you manually change pyproject.toml to name = "test_package"

[dimbleby]

that is the correctly normalized package name, not a bug

[Gerrit-K]

You're right, sorry. I somehow didn't find PEP-503 when researching this.

[Gerrit-K]

Though, on second thought, I'd argue that poetry version should at least return whatever is set as name. This is done correctly in poetry publish, e.g. name = "test_package" is correctly published as test_package, but poetry version results in test-package 0.1.0.

@dimbleby is this also by design?

[dimbleby]

🤷

if you want to submit a merge request changing package.name to package.pretty_name at

poetry/src/poetry/console/commands/version.py

Line 89 in 022308e

f"<comment>{self.poetry.package.name}</>"

then I wouldn't much care either way, but no doubt a maintainer would take a view

[Gerrit-K]

Alright, thank you! I'll take a look

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.