Export command produces requirements.txt with git dev dependency #875

laactech · 2019-02-09T18:33:43Z

I am on the latest Poetry version.
I have searched the issues of this repo and believe that this is not a duplicate.
If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: Ubuntu 18.04
Poetry version: 1.0.0a2
Link of a Gist with the contents of your pyproject.toml file:

[tool.poetry]
name = "poetry_bug"
version = "0.1.0"
description = ""
authors = ["Steven Pate <[email protected]>"]

[tool.poetry.dependencies]
python = "^3.6"
django = "^2.1"

[tool.poetry.dev-dependencies]
pytest = "^4.2"
webassets = {git = "https://github.com/miracle2k/webassets.git"}

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"

Issue

First off, poetry is awesome. Thank you for a great step forward in Python dependency management.

Using the above pyproject.toml, I run poetry export -f requirements.txt, and it produces this requirements.txt

django==2.1.5 \
    --hash=sha256:a32c22af23634e1d11425574dce756098e015a165be02e4690179889b207c7a8 \
    --hash=sha256:d6393918da830530a9516bbbcbf7f1214c3d733738779f06b0f649f49cc698c3
pytz==2018.9 \
    --hash=sha256:32b0891edff07e28efe91284ed9c31e123d84bea3fd98e1f72be2508f43ef8d9 \
    --hash=sha256:d5f05e487007e29e03409f9398d074e158d920d36eb82eaf66fb1136b0c5374c
-e git+https://github.com/miracle2k/webassets.git@d1f3455e383446ca4ab0c644f326ee937e68e809#egg=webassets

webassets is included in the requirements.txt without adding the --dev to the export command.

The text was updated successfully, but these errors were encountered:

kingtut · 2019-05-31T03:14:48Z

Also:

$ poetry export --no-dev --without-hashes -f requirements.txt

[NoSuchOptionException]
The "--no-dev" option does not exist.

We would like to use the export function for production builds, using Serverless Framework.

Any such feature on the horizon?

kingtut · 2019-05-31T03:22:46Z

TODO has been added for fixing this.

#313

laactech · 2019-05-31T14:28:27Z

Also:
$ poetry export --no-dev --without-hashes -f requirements.txt

[NoSuchOptionException]
The "--no-dev" option does not exist.
We would like to use the export function for production builds, using Serverless Framework.

Any such feature on the horizon?

The argument should be --dev to include development dependencies. Development dependencies are excluded from the export by default.

Using 1.0.0a3, I run poetry export --help, and it shows --dev

im-n1 · 2019-09-18T14:04:12Z

Just ran into this using 1.0.0b1 - still active. Needs to be solved.

stale · 2019-11-17T15:03:30Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

im-n1 · 2019-11-18T09:26:34Z

[An activity against robot auto-closing (which won't solve the issue at all)]

SimonBiggs · 2019-12-10T10:55:29Z

I'd like to add extra debugging info to this issue. Using poetry-1.0.0b9-linux calling poetry export -f requirements.txt --without-hashes with the following pyproject.toml results in optional dependencies such as pytest being included even though no --extras flag was used.

`pyproject.toml`

[tool.poetry]
name = "pymedphys"
version = "0.13.2"
readme = "README.rst"
description = "Medical Physics library"
authors = [
    "PyMedPhys Contributors <[email protected]>",
    "Simon Biggs <[email protected]>",
    "Matthew Jennings <[email protected]>>",
    "Phillip Chlap",
    "Paul King <[email protected]>",
    "Matthew Sobolewski <[email protected]>",
    "Jacob McAloney",
    "Pedro Martinez"
]
license = "AGPL-3.0-or-later"
homepage = "https://pymedphys.com"
repository = "https://github.com/pymedphys/pymedphys"
documentation = "https://pymedphys.com"
classifiers = [
    "Development Status :: 4 - Beta",
    "Topic :: Scientific/Engineering :: Medical Science Apps.",
    "Topic :: Scientific/Engineering :: Physics",
    "Intended Audience :: Science/Research",
    "Intended Audience :: Healthcare Industry",
]

[tool.poetry.dependencies]
python = "^3.7"

attrs = "*"
keyring = "*"
packaging = "*"
PyYAML = "*"

numpy = "^1.12"
matplotlib = "*"
scipy = "*"
pandas = "*"

dbfread = "*"

pydicom = "*"
pynetdicom = "*"

pymssql = "< 3.0.0"
shapely = { version = "*", optional = true }

# labs
tqdm = "*"
python_dateutil = "*"
Pillow = "*"
imageio = "*"
scikit-image = "*"

# docs
sphinx = { version = ">= 1.4, < 1.8", optional = true }
sphinx-rtd-theme  = { version = "^0.4.3", optional = true }
sphinx-autobuild = { version = "*", optional = true }
sphinxcontrib-napoleon = { version = "*", optional = true }
sphinx-argparse  = { version = "*", optional = true }
nbsphinx  = { version = "*", optional = true }
jupyter_client = { version = "*", optional = true }
ipython = { version = "*", optional = true }
ipykernel = { version = "*", optional = true }
m2r = { version = "*", optional = true }

# pytest
pytest = { version = "*", optional = true }
pytest-sugar  = { version = "*", optional = true }
hypothesis  = { version = "*", optional = true }

# pylint
pylint  = { version = "*", optional = true }
pytest-pylint  = { version = "*", optional = true }


[tool.poetry.dev-dependencies]
# Testing
tox = "*"
pytest = "*"
pytest-sugar = "*"
pylint = "*"
pytest-pylint = "*"
hypothesis = "*"

# Git Management
pre-commit = "*"

# VSCode linting and formatting
black = "^19.3b0"
mypy = "*"
rope = "*"

# Building documentation
sphinx = ">= 1.4, < 1.8"
sphinx-rtd-theme = "*"
sphinx-autobuild = "*"
sphinxcontrib-napoleon = "*"
sphinx-argparse = "*"
nbsphinx = "*"
jupyter_client = "*"
ipython = "*"
ipykernel = "*"
m2r = "*"

# Supporting JupyterLab usage
pywin32 = { version = "224", platform = "win32" }

# VSCode extension dependencies
doc8 = "*"

# gui
cefpython3 = "66.0"
jupyterlab_server = "*"

# Packages to include later
# pytest-cov = "^2.5"
# pytest-mock = "^1.9"

[tool.poetry.extras]
docs = [
    "sphinx", "sphinx-rtd-theme",
    "sphinx-autobuild", "sphinxcontrib-napoleon", "sphinx-argparse",
    "nbsphinx", "jupyter_client", "ipython", "ipykernel",
    "m2r"
]

extras = [
    "shapely"
]

pytest = [
    "pytest", "pytest-sugar", "hypothesis"
]

pylint = [
    "pylint", "pytest-pylint"
]

[tool.poetry.scripts]
pymedphys = "pymedphys.cli.main:pymedphys_cli"

[tool.isort]
multi_line_output = 3
line_length = 88
include_trailing_comma = true
known_third_party = [
    "attr", "tqdm", "pytest", "hypothesis", "cefpython3", "notebook",
    "jupyterlab", "traitlets", "jupyterlab_server", "packaging", "dateutil"
]
known_scicore = [
    "numpy", "scipy", "pandas"
]
known_matplotlib = [
    "matplotlib", "mpl_toolkits"
]
known_sci_other = [
    "imageio", "PIL", "skimage"
]
known_medphys = [
    "pydicom", "pylinac"
]
known_first_party = ["pymedphys"]
sections = [
    "FUTURE", "STDLIB", "THIRDPARTY", "SCICORE", "MATPLOTLIB", "SCI_OTHER",
    "MEDPHYS", "FIRSTPARTY", "LOCALFOLDER"
]

[build-system]
requires = ["poetry >= 0.12", "setuptools >= 35.0.2", "wheel >= 0.29.0"]
build-backend = "poetry.masonry.api"

`poetry export -f requirements.txt --without-hashes`

alabaster==0.7.12
appnope==0.1.0; sys_platform == "darwin" or platform_system == "Darwin"
argh==0.26.2
astroid==2.3.3
atomicwrites==1.3.0; sys_platform == "win32"
attrs==19.3.0
babel==2.7.0
backcall==0.1.0
bleach==3.1.0
certifi==2019.11.28
cffi==1.13.2; sys_platform == "linux"
chardet==3.0.4
colorama==0.4.1; sys_platform == "win32"
cryptography==2.8; sys_platform == "linux"
cycler==0.10.0
dbfread==2.0.7
decorator==4.4.1
defusedxml==0.6.0
docutils==0.15.2
entrypoints==0.3
hypothesis==4.50.6
idna==2.8
imageio==2.6.1
imagesize==1.1.0
importlib-metadata==0.23; python_version < "3.8"
ipykernel==5.1.3
ipython==7.10.1
ipython-genutils==0.2.0
isort==4.3.21
jedi==0.15.1
jeepney==0.4.1; sys_platform == "linux"
jinja2==2.10.3
jsonschema==3.2.0
jupyter-client==5.3.4
jupyter-core==4.6.1
keyring==19.3.0
kiwisolver==1.1.0
lazy-object-proxy==1.4.3
livereload==2.6.1
m2r==0.2.1
markupsafe==1.1.1
matplotlib==3.1.2
mccabe==0.6.1
mistune==0.8.4
more-itertools==8.0.0
nbconvert==5.6.1
nbformat==4.4.0
nbsphinx==0.4.3
networkx==2.4
numpy==1.17.4
packaging==19.2
pandas==0.25.3
pandocfilters==1.4.2
parso==0.5.1
pathtools==0.1.2
pexpect==4.7.0; sys_platform != "win32"
pickleshare==0.7.5
pillow==6.2.1
pluggy==0.13.1
pockets==0.9.1
port-for==0.3.1
prompt-toolkit==3.0.2
ptyprocess==0.6.0; sys_platform != "win32" or os_name != "nt"
py==1.8.0
pycparser==2.19; sys_platform == "linux"
pydicom==1.3.0
pygments==2.5.2
pylint==2.4.4
pymssql==2.1.4
pynetdicom==1.4.1
pyparsing==2.4.5
pyrsistent==0.15.6
pytest==5.3.1
pytest-pylint==0.14.1
pytest-sugar==0.9.2
python-dateutil==2.8.1
pytz==2019.3
pywavelets==1.1.1
pywin32==224; sys_platform == "win32"
pywin32-ctypes==0.2.0; sys_platform == "win32"
pyyaml==5.1.2
pyzmq==18.1.1
requests==2.22.0
scikit-image==0.16.2
scipy==1.3.3
secretstorage==3.1.1; sys_platform == "linux"
six==1.13.0
snowballstemmer==2.0.0
sphinx==1.7.9
sphinx-argparse==0.2.5
sphinx-autobuild==0.7.1
sphinx-rtd-theme==0.4.3
sphinxcontrib-napoleon==0.7
sphinxcontrib-websupport==1.1.2
termcolor==1.1.0
testpath==0.4.4
tornado==6.0.3
tqdm==4.40.0
traitlets==4.3.3
typed-ast==1.4.0
urllib3==1.25.7
watchdog==0.9.0
wcwidth==0.1.7
webencodings==0.5.1
wrapt==1.11.2
zipp==0.6.0; python_version < "3.8"

sisp · 2019-12-12T16:57:32Z

The problem seems to be that the Git dependency belongs to category main in poetry.lock although it is listed under [tool.poetry.dev-dependencies] in pyproject.toml. It looks like the locker has a bug.

sisp · 2019-12-12T17:45:06Z

In fact, it's not the locker, but when the VCSDependency instance of a Git package is created, category is not passed as an argument to the class constructor. In VCSDependency's parent class constructor Dependency.__init__, category has a default value "main". That's why any VCS dependency has category "main".

I'd be happy to create a PR to fix this issue.

sisp · 2019-12-13T10:05:49Z

I've created a PR that fixes this issue.

github-actions · 2024-03-03T09:04:49Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

stale bot added the stale label Nov 17, 2019

stale bot removed the stale label Nov 18, 2019

sisp mentioned this issue Dec 13, 2019

Lock VCS dev-dependencies as category "dev" #1725

Merged

2 tasks

sdispater closed this as completed in #1725 Dec 20, 2019

burkovae mentioned this issue Apr 8, 2020

Poetry removes importlib_metadata and other requirements when run as --no-dev #2102

Closed

3 tasks

demus mentioned this issue Oct 11, 2022

Export command requires dev source dependencies to be present python-poetry/poetry-plugin-export#148

Open

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export command produces requirements.txt with git dev dependency #875

Export command produces requirements.txt with git dev dependency #875

laactech commented Feb 9, 2019 •

edited

Loading

kingtut commented May 31, 2019 •

edited

Loading

kingtut commented May 31, 2019

laactech commented May 31, 2019

im-n1 commented Sep 18, 2019

stale bot commented Nov 17, 2019

im-n1 commented Nov 18, 2019

SimonBiggs commented Dec 10, 2019 •

edited

Loading

sisp commented Dec 12, 2019

sisp commented Dec 12, 2019 •

edited

Loading

sisp commented Dec 13, 2019

github-actions bot commented Mar 3, 2024

Export command produces requirements.txt with git dev dependency #875

Export command produces requirements.txt with git dev dependency #875

Comments

laactech commented Feb 9, 2019 • edited Loading

Issue

kingtut commented May 31, 2019 • edited Loading

kingtut commented May 31, 2019

laactech commented May 31, 2019

im-n1 commented Sep 18, 2019

stale bot commented Nov 17, 2019

im-n1 commented Nov 18, 2019

SimonBiggs commented Dec 10, 2019 • edited Loading

pyproject.toml

poetry export -f requirements.txt --without-hashes

sisp commented Dec 12, 2019

sisp commented Dec 12, 2019 • edited Loading

sisp commented Dec 13, 2019

github-actions bot commented Mar 3, 2024

laactech commented Feb 9, 2019 •

edited

Loading

kingtut commented May 31, 2019 •

edited

Loading

SimonBiggs commented Dec 10, 2019 •

edited

Loading

`pyproject.toml`

`poetry export -f requirements.txt --without-hashes`

sisp commented Dec 12, 2019 •

edited

Loading