Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency file inheritance #8317

Closed
2 tasks done
JudahSchwartz opened this issue Aug 16, 2023 · 4 comments
Closed
2 tasks done

dependency file inheritance #8317

JudahSchwartz opened this issue Aug 16, 2023 · 4 comments
Labels
kind/feature Feature requests/implementations

Comments

@JudahSchwartz
Copy link

JudahSchwartz commented Aug 16, 2023

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

Declare that a certain prproject.toml file inherits from another

Usecase:
I manage many different python based docker images, each of which has its own set of python dependencies and os dependencies if relevant. all of them are based on our base_python image (FROM base_python) which has some dependencies (os and python) required for every one of our images.
Certifi, for example, is in our base image.
Currently each docker image has its own poetry file, some of which redeclare certifi (in either the pyproject.toml or the lock file)
When building the image, if the certifi version is lower than the 1 we have on base, certifi would get downgraded. (relocking the child's file isnt always possible, we maintain more than 100 of these images)

Would be nice if I could have childproject.toml depend on parentproject.toml, so that it would know not to get downgraded (maybe the lock should be inherited somehow? certifi shouldnt be redeclared.)

If you dont think this is the proper solution, any advice on how to solve this problem would be helpful =)

@JudahSchwartz JudahSchwartz added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Aug 16, 2023
@wagnerluis1982
Copy link
Contributor

This is a duplicate of the issue #2270, isn't it?

@JudahSchwartz
Copy link
Author

this isnt the same usecase

@abn
Copy link
Member

abn commented Mar 3, 2024

While the use case is not explicitly the same, since #2270 will resolve this use case as well closing as duplicate for now.

@abn abn closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

3 participants