pep-561 tests fails (missing tests/masonry/builders/fixtures/pep_561_stub_only/pkg-stubs)

[mtelka]

• Poetry version: poetry_core-1.6.0

• Python version: 3.9.16

• OS version and name: OpenIndiana Hipster

• pyproject.toml: NA

• [x ] I am on the latest stable Poetry version, installed using a recommended method.

• [x ] I have searched the issues of this repo and believe that this is not a duplicate.

• [x ] I have consulted the FAQ and blog for any relevant entries or release notes.

• [x ] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

Steps to reproduce:

$ cd /tmp
$ wget https://github.com/python-poetry/poetry-core/releases/download/1.6.0/poetry_core-1.6.0.tar.gz
$ tar xf poetry_core-1.6.0.tar.gz
$ cd poetry_core-1.6.0
$ PYTHONPATH=$(pwd)/src pytest
... snip (see below) ...
=========================== short test summary info ============================
FAILED tests/masonry/builders/test_sdist.py::test_sdist_package_pep_561_stub_only
FAILED tests/masonry/builders/test_wheel.py::test_wheel_package_pep_561_stub_only[pep_561_stub_only]
FAILED tests/masonry/builders/test_wheel.py::test_wheel_package_pep_561_stub_only[pep_561_stub_only_partial]
FAILED tests/masonry/builders/test_wheel.py::test_wheel_package_pep_561_stub_only[pep_561_stub_only_src]
FAILED tests/masonry/builders/test_wheel.py::test_wheel_package_pep_561_stub_only_partial_namespace
FAILED tests/masonry/utils/test_package_include.py::test_pep_561_stub_only_package_good_name_suffix
FAILED tests/masonry/utils/test_package_include.py::test_pep_561_stub_only_partial_namespace_package_good_name_suffix
FAILED tests/masonry/utils/test_package_include.py::test_pep_561_stub_only_package_bad_name_suffix
FAILED tests/utils/test_helpers.py::test_robust_rmtree - AttributeError: 'Moc...
$

(Note to myself: there should be gcc available in PATH.)

Full log:
poetry_core.log

Apparently, the root cause is missing tests/masonry/builders/fixtures/pep_561_stub_only/pkg-stubs in sdist.

[mtelka]

Please note that the test_robust_rmtree failure is not related to this issue.

[dimbleby]

https://github.com/python-poetry/poetry-core/blob/0b4c8c70fe9520874ad274a5da3759e4b371ce45/pyproject.toml#L29

so far as I can see there's no good reason to exclude .pyi files - the only such files in the poetry-core repository are ones in test fixtures that probably should be present in the sdist. So probably the fix is just: don't do that.

Feel free to put together a merge request

[dimbleby]

as for the other it looks as though you want a more recent version of pytest-mock. Again a merge request bumping the lower bound in poetry-core's pyproject.toml is surely welcome

[mtelka]

as for the other it looks as though you want a more recent version of pytest-mock. Again a merge request bumping the lower bound in poetry-core's pyproject.toml is surely welcome

Yes, you are right. I do have pytest-mock-3.7.0 and stop was added to MockerFixture in 3.10.0.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.