Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I request that classifiers in METADATA what is created at build command are unique #7857

Closed
2 tasks done
yuji38kwmt opened this issue May 1, 2023 · 3 comments · Fixed by python-poetry/poetry-core#578
Closed
2 tasks done
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@yuji38kwmt
Copy link

yuji38kwmt commented May 1, 2023

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

When executing poetry build, poetry automatically added python requirement classifiers and license classifier.

When python requirement classifiers are already listed in pyproject.toml , classifiers in dist/*.whl/*.dist-info/METADATA are duplicated

An example is shown below.

[tool.poetry]
name = "yuji38kwmt-cli"
version = "0.1.0"
description = "yuji38kwmt's CLI"
authors = ["yuji38kwmt"]
license = "MIT"
classifiers = [
    "Operating System :: OS Independent",
    "Operating System :: OS Independent",
    "License :: OSI Approved :: MIT License",
    "Programming Language :: Python :: 3",
    "Programming Language :: Python :: 3.9",
    "Programming Language :: Python :: 3.10",
    "Programming Language :: Python :: 3.11",
]

packages = [
    { include = "yuji38kwmt_cli" }
]

[tool.poetry.dependencies]
python = "^3.9"
requests = "*"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"
$ poetry build --quiet

$ unzip -c  dist/yuji38kwmt_cli-0.1.0-py3-none-any.whl yuji38kwmt_cli-0.1.0.dist-info/METADATA | cat
Archive:  dist/yuji38kwmt_cli-0.1.0-py3-none-any.whl
  inflating: yuji38kwmt_cli-0.1.0.dist-info/METADATA  
Metadata-Version: 2.1
Name: yuji38kwmt-cli
Version: 0.1.0
Summary: yuji38kwmt's CLI
License: MIT
Author: yuji38kwmt
Requires-Python: >=3.9,<4.0
Classifier: License :: OSI Approved :: MIT License
Classifier: Operating System :: OS Independent
Classifier: Programming Language :: Python :: 3
Classifier: Programming Language :: Python :: 3.9
Classifier: Programming Language :: Python :: 3.10
Classifier: Programming Language :: Python :: 3.11
Classifier: Programming Language :: Python :: 3
Classifier: Programming Language :: Python :: 3.10
Classifier: Programming Language :: Python :: 3.11
Classifier: Programming Language :: Python :: 3.9
Requires-Dist: requests

Operating System and License classifiers are unique. But Programming Language classifiers are duplicated.

I request that Programming Language classifiers are also unique.

@yuji38kwmt yuji38kwmt added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels May 1, 2023
@dimbleby
Copy link
Contributor

dimbleby commented May 2, 2023

code looks as though it's here, submit a merge request!

@yuji38kwmt
Copy link
Author

yuji38kwmt commented May 3, 2023

OK! I create pull request python-poetry/poetry-core#578 .

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
2 participants