Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not have PowerShell one-liner to activate virtual environment #6653

Closed
1 task done
avysk opened this issue Sep 29, 2022 · 7 comments · Fixed by #6683
Closed
1 task done

Documentation does not have PowerShell one-liner to activate virtual environment #6653

avysk opened this issue Sep 29, 2022 · 7 comments · Fixed by #6683
Labels
area/docs Documentation issues/improvements good first issue

Comments

@avysk
Copy link
Contributor

avysk commented Sep 29, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

There is no PowerShell one-liner specified in the documentation to activate the project's virtual environment. The following works: & ((poetry env info --path) + "\Scripts\activate.ps1")

@avysk avysk added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Sep 29, 2022
@finswimmer
Copy link
Member

What's wrong with poetry shell?

@avysk
Copy link
Contributor Author

avysk commented Sep 29, 2022

Nothing, except it does another thing, and there's bash but not PowerShell one-liner in the docs.

@venaturum
Copy link
Contributor

@avysk what's the use case for it in lieu of poetry shell?

@avysk
Copy link
Contributor Author

avysk commented Sep 30, 2022

The idea of this bug was not to discuss relative merits of poetry shell but to point out the obvious inconsistency in the documentation.

@dimbleby
Copy link
Contributor

An MR would probably be welcome

@finswimmer
Copy link
Member

Ah, now I see that you are talking about this page in the documentation https://python-poetry.org/docs/basic-usage/#activating-the-virtual-environment

As @dimbleby said: A Pull Request is welcome. The file that needs to be edited is https://github.com/python-poetry/poetry/blob/master/docs/basic-usage.md

@finswimmer finswimmer removed the status/triage This issue needs to be triaged label Oct 1, 2022
neersighted added a commit that referenced this issue Oct 2, 2022
Based on #6653, and closes #6653. Also supersedes and closes #5987.

Co-authored-by: Alexey Vyskubov <[email protected]>
Co-authored-by: lbr <[email protected]>
neersighted added a commit that referenced this issue Oct 2, 2022
Based on and closes #6653. Also supersedes and closes #5987.

Co-authored-by: Alexey Vyskubov <[email protected]>
Co-authored-by: lbr <[email protected]>
neersighted added a commit that referenced this issue Oct 2, 2022
Based on and closes #6653. Also supersedes and closes #5987.

Co-authored-by: Alexey Vyskubov <[email protected]>
Co-authored-by: lbr <[email protected]>
poetry-bot bot pushed a commit that referenced this issue Oct 2, 2022
Based on and closes #6653. Also supersedes and closes #5987.

Co-authored-by: Alexey Vyskubov <[email protected]>
Co-authored-by: lbr <[email protected]>
(cherry picked from commit 2c610de)
neersighted added a commit that referenced this issue Oct 2, 2022
Based on and closes #6653. Also supersedes and closes #5987.

Co-authored-by: Alexey Vyskubov <[email protected]>
Co-authored-by: lbr <[email protected]>
(cherry picked from commit 2c610de)
rzuckerm pushed a commit to rzuckerm/poetry that referenced this issue Oct 2, 2022
Based on and closes python-poetry#6653. Also supersedes and closes python-poetry#5987.

Co-authored-by: Alexey Vyskubov <[email protected]>
Co-authored-by: lbr <[email protected]>
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants