Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules are not checked out recursively #6033

Closed
3 tasks done
tomuben opened this issue Jul 19, 2022 · 4 comments · Fixed by python-poetry/poetry-core#439
Closed
3 tasks done

Submodules are not checked out recursively #6033

tomuben opened this issue Jul 19, 2022 · 4 comments · Fixed by python-poetry/poetry-core#439
Labels
kind/bug Something isn't working as expected status/waiting-on-core Requires changes to poetry-core first

Comments

@tomuben
Copy link

tomuben commented Jul 19, 2022

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

My project contains a submodule. (Actually the pyproject.toml is in the submodule, but I think this does not matter). The clone works as expected, considering the submodule. However, the checkout for a specific branch, does not update the submodule:
This line should be:

args += ["checkout", "--recurse-submodules", rev]
@tomuben tomuben added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jul 19, 2022
@finswimmer
Copy link
Member

Hello @tomuben,

thanks a lot for reporting. Your suggestion looks reasonable to me. I'm happy to review a PR ;)

fin swimmer

@finswimmer finswimmer added status/waiting-on-core Requires changes to poetry-core first Good First Issue and removed status/triage This issue needs to be triaged labels Jul 20, 2022
@evanrittenhouse
Copy link
Contributor

@finswimmer Sorry for the basic question, but how do I submit a PR for poetry-core changes when the issue is filed in poetry? Should I just replicate the issue in poetry-core and then submit the PR against that repo? I have the code ready on my local.

@radoering
Copy link
Member

We don't track poetry-core issues separately. Just submit the PR and link this issue (python-poetry/poetry#6033). See also other poetry-core PRs for example.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected status/waiting-on-core Requires changes to poetry-core first
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants