Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build artifacts omit period from .dev segment (1.2.0b1) #5534

Closed
3 tasks done
mtkennerly opened this issue May 3, 2022 · 2 comments · Fixed by python-poetry/poetry-core#344
Closed
3 tasks done

Build artifacts omit period from .dev segment (1.2.0b1) #5534

mtkennerly opened this issue May 3, 2022 · 2 comments · Fixed by python-poetry/poetry-core#344
Labels
kind/bug Something isn't working as expected

Comments

@mtkennerly
Copy link

mtkennerly commented May 3, 2022

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: Windows 11
  • Poetry version: 1.2.0b1
  • pyproject.toml (just change the version to 1.11.1.dev1)

Issue

On 1.1.13, when the project version contains .devN, the build artifacts correctly contain a dot before dev:

$ grep -m 1 'version =' pyproject.toml
version = "1.11.1.dev1"

$ pip list | grep poetry
poetry                            1.1.13
poetry-core                       1.0.8

$ poetry version --short
1.11.1.dev1

$ poetry build
Building dunamai (1.11.1.dev1)
  - Building sdist
  - Built dunamai-1.11.1.dev1.tar.gz
  - Building wheel
  - Built dunamai-1.11.1.dev1-py3-none-any.whl

However, on 1.2.0b1, the dot is omitted, which violates PEP 440:

$ pip list | grep poetry
poetry                            1.2.0b1
poetry-core                       1.1.0a7

$ poetry version --short
1.11.1.dev1

$ poetry build
Building dunamai (1.11.1.dev1)
  - Building sdist
  - Built dunamai-1.11.1dev1.tar.gz
  - Building wheel
  - Built dunamai-1.11.1dev1-py3-none-any.whl
@mtkennerly mtkennerly added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels May 3, 2022
@dimbleby
Copy link
Contributor

dimbleby commented May 3, 2022

python-poetry/poetry-core#140.

Consider:

from poetry.core.utils.helpers import normalize_version

output = normalize_version("1.2.3.dev0")

Before, the output is 1.2.3.dev0. After, 1.2.3dev0.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants