Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency get's removed from lock file #5351

Closed
3 tasks done
kasium opened this issue Mar 24, 2022 · 3 comments
Closed
3 tasks done

Dependency get's removed from lock file #5351

kasium opened this issue Mar 24, 2022 · 3 comments
Labels
kind/bug Something isn't working as expected

Comments

@kasium
Copy link

kasium commented Mar 24, 2022

  • I am on the latest Poetry version.

  • I have searched the issues of this repo and believe that this is not a duplicate.

  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

  • OS version and name: Linux

  • Poetry version: 1.1.13

Issue

I have the following in my dependency list

[tool.poetry.dev-dependencies]
diff-cover = {version = "==6.4.4", extras = ["toml"]}

diff-cover depends on setuptools if you run on python < 3.8.
However, a install doesn't install setuptools and it's not listed in the lock file as a depdency of diff-cover

[[package]]
name = "diff-cover"
version = "6.4.4"
description = "Run coverage and linting reports on diffs"
category = "dev"
optional = false
python-versions = ">=3.6.2,<4.0.0"

[package.dependencies]
chardet = ">=3.0.0"
Jinja2 = ">=2.7.1"
pluggy = ">=0.13.1,<2"
Pygments = ">=2.9.0,<3.0.0"
tomli = {version = ">=1.2.1,<2.0.0", optional = true, markers = "extra == \"toml\""}

However, if using poetry 1.2.0b1, the following line will appear in the lock file
setuptools = {version = ">=17.0.0", markers = "python_version < \"3.8\""}

I report this bug even if (maybe) fixed, since 1.1 doesn't include it

@kasium kasium added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Mar 24, 2022
@finswimmer
Copy link
Member

Hello @kasium,

please see #1584 for the whole story. Especially #1584 (comment) and #1584 (comment).

TL;DR: Poetry haven't locked setuptools explicit before version 1.2 and will do it now.

fin swimmer

@kasium
Copy link
Author

kasium commented Mar 24, 2022

thanks a lot!

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants