Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different git links when installing from tar.gz vs whl #5024

Open
2 tasks done
ashnair1 opened this issue Jan 11, 2022 · 0 comments
Open
2 tasks done

Different git links when installing from tar.gz vs whl #5024

ashnair1 opened this issue Jan 11, 2022 · 0 comments
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) status/triage This issue needs to be triaged

Comments

@ashnair1
Copy link
Contributor

ashnair1 commented Jan 11, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Issue

This builds off of #4380. I wanted to add a dependency that was a git link rooted in a subfolder. To do this, as discussed in #4567, I used poetry-core from master since I needed python-poetry/poetry-core#192.

Relevant lines in pyproject.toml:

[build-system]
requires = ["poetry-core @ git+https://github.com/python-poetry/poetry-core.git"]
build-backend = "poetry.core.masonry.api"

[tool.poetry.dependencies]
python = ">=3.7.1,<4.0"
pycocotools = {git = "https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI"}

This works for installing the package from source and from tar.gz file but not from whl and the only difference seems to be a branch tag added at the end of the git link while installing from whl. I've attached the relevant lines below

The tar.gz and whl files were created via poetry build

  • From tar.gz
Collecting pycocotools@ git+https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI
  Cloning https://github.com/ashnair1/cocoapi.git to /tmp/pip-install-ylghq7w3/pycocotools_04a986d205554860a5a783224ef1f8d8
  Running command git clone --filter=blob:none -q https://github.com/ashnair1/cocoapi.git /tmp/pip-install-ylghq7w3/pycocotools_04a986d205554860a5a783224ef1f8d8
  Resolved https://github.com/ashnair1/cocoapi.git to commit 2ab05524360647addb03d0d347288cda2b41b392
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
  • From whl
Collecting pycocotools@ git+https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI@master
  Cloning https://github.com/ashnair1/cocoapi.git to /tmp/pip-install-z7v4apwo/pycocotools_16adbb699d6243728216a980f2c8a477
  Running command git clone --filter=blob:none -q https://github.com/ashnair1/cocoapi.git /tmp/pip-install-z7v4apwo/pycocotools_16adbb699d6243728216a980f2c8a477
  Resolved https://github.com/ashnair1/cocoapi.git to commit 2ab05524360647addb03d0d347288cda2b41b392
ERROR: pycocotools@ git+https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI@master from git+https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI@master (from coco-assistant==0.4.0) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

As you can see while installing from tar.gz there is no branch tag (@master)

Collecting pycocotools@ git+https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI

whereas while installing from whl there is

Collecting pycocotools@ git+https://github.com/ashnair1/cocoapi.git#egg=pycocotools&subdirectory=PythonAPI@master

So my question is whether it is possible to not have the @master tag while installing from whl? (assuming this is the cause of the error)

@finswimmer finswimmer added area/build-system Related to PEP 517 packaging (see poetry-core) status/triage This issue needs to be triaged labels Jan 11, 2022
@ashnair1 ashnair1 changed the title Differing git link when installing from tar.gz vs whl Different git links when installing from tar.gz vs whl Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants