-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Include combination gives wrong results #4711
Comments
Hello @nylocx, thanks for reporting. I can confirm this bug and a fix is on the way: python-poetry/poetry-core#228 fin swimmer |
Wao, that was a quick one, thanks! |
I just checked in it does not work as I expected here is the result of the wheel. It still contains the pyx file. Any idea what is going wrong there? As the test looks like it should check for this. --- edit |
@finswimmer I really don't want to annoy you but can you give an approximate ETA when this will land in poetry? I think it was not included in core 1.0.8 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).Issue
To setup a reproducible environment just run:
poetry new poetry-cython-demo cd poetry-cython-demo mkdir poetry_cython_demo/compiled touch poetry_cython_demo/cython_code.pyx poetry_cython_demo/compiled/source.c poetry_cython_demo/compiled/source.h
and replace the pyproject.toml with the gist version.
Then run:
The expected result is that the sdist package includes the C sources and the .pyx file and the wheel only includes the
__init__.py
.The actual result is that the wheel includes the .pyx file.
As a side note, my first expectation was that include is working recursively as exclude, so I thought
{ path = "poetry_cython_demo/compiled", format = "sdist" }
would be enough, but than the result is even stranger output where sdist and wheel seam to be switched:
The text was updated successfully, but these errors were encountered: