Resolver fails on URL dependencies for different installations

[MetcalfeTom]

• I am on the latest Poetry version.

• I have searched the issues of this repo and believe that this is not a duplicate.

• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: macOS Big Sur 11.2.3

• Poetry version: 1.1.6

Issue

When building a first package with a URL dependency, any other package depending on it fails when specifying a version

Example:

[tool.poetry]
name = "some_package"
version = "2.0.0"

[tool.poetry.dependencies]
torch = { url = "https://download.pytorch.org/whl/cu110/torch-1.7.1%2Bcu110-cp38-cp38-linux_x86_64.whl" }

Now depending on that package and specifying a version of torch:

[tool.poetry]
name = "some_other_package"
version = "2.0.0"

[tool.poetry.dependencies]
some_package = "2.0.0"
torch = "*"

Leads to the following:

SolverProblemError

Because some_other_package depends on some_package (2.0.0) which depends on torch (1.7.1+cu110), torch is required.
So, because some_other_package depends on torch (*), version solving failed.

This makes it impossible to support multiple-constraint dependencies that contain URLs, which was something I attempted as a solution to #2613

[MetcalfeTom]

I'd like to work on this issue

As I see it, the problem arises in poetry-core due to the PackageSpecification.is_same_package_as() function being too stringent on URLs:

https://github.com/python-poetry/poetry-core/blob/58138c580210c473190f0513d6f1f6f0a86f6255/poetry/core/packages/specification.py#L67-L77

Would it be suitable to override this method for URLDependency with some reference to the version/constraint of the package instead of checking the URL matches?

@python-poetry/triage

[dimbleby]

works now, please close

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.