Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel_file_re does not match version correctly #3320

Closed
3 tasks done
radek-sprta opened this issue Nov 3, 2020 · 9 comments
Closed
3 tasks done

wheel_file_re does not match version correctly #3320

radek-sprta opened this issue Nov 3, 2020 · 9 comments
Labels
kind/bug Something isn't working as expected

Comments

@radek-sprta
Copy link
Contributor

radek-sprta commented Nov 3, 2020

Issue

wheel_file_re fails to match version for packages with single digit versions. Example is markdown-captions package (filename markdown_captions-2-py3-none-any.whl). Results in the following error:

  • Installing markdown-captions (2): Failed

  AttributeError

  'NoneType' object has no attribute 'replace'

  at ~/.poetry/lib/poetry/installation/chooser.py:27 in __init__
       23│             raise InvalidWheelName("{} is not a valid wheel filename.".format(filename))
       24│ 
       25│         self.filename = filename
       26│         self.name = wheel_info.group("name").replace("_", "-")
    →  27│         self.version = wheel_info.group("ver").replace("_", "-")
       28│         self.build_tag = wheel_info.group("build")
       29│         self.pyversions = wheel_info.group("pyver").split(".")
       30│         self.abis = wheel_info.group("abi").split(".")
       31│         self.plats = wheel_info.group("plat").split(".")
@radek-sprta radek-sprta added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Nov 3, 2020
@sinoroc
Copy link

sinoroc commented Nov 3, 2020

I could recreate the issue with poetry add markdown-captions.

@python-poetry/triage
Seems like a severe enough bug.

@abn
Copy link
Member

abn commented Nov 3, 2020

@python-poetry/triage

@matinalsun
Copy link

I could recreate the issue with poetry run bootstrap

@finswimmer
Copy link
Member

Fix is ready for review #3338

@dhiltonp
Copy link

#3411 adds a test for this issue with Wheel

@muppetjones
Copy link

Any update on when this fix will be merged and released?

@jma
Copy link

jma commented Mar 30, 2021

Any update on when this fix will be merged and released?

+1

@kasteph
Copy link
Member

kasteph commented Mar 30, 2021

#3338 merged.

@kasteph kasteph closed this as completed Mar 30, 2021
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

9 participants