Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use 1.x for 1.1 release, use a 2.x #2384

Closed
dazza-codes opened this issue May 5, 2020 · 2 comments
Closed

Don't use 1.x for 1.1 release, use a 2.x #2384

dazza-codes opened this issue May 5, 2020 · 2 comments
Labels
kind/feature Feature requests/implementations

Comments

@dazza-codes
Copy link
Contributor

2c - looks like release 1.1.x will break all the projects using any 1.0.x versions of poetry because the TOML specs/schema is changing, so this should be a 2.x release and then any patches for bug-fixes etc. can be applied to the 1.x series as expected.

@dazza-codes dazza-codes added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels May 5, 2020
@sdispater
Copy link
Member

Is this related to #2361?

This introduces changes to the lock file which are backwards compatible (new versions of Poetry won't break with the older lock files) but not forward compatible (older versions of Poetry might break with this new lock file format).

If so then I don't think it warrants a major version bump since it's backwards compatible. Forward compatibility was never a promise and does not affect the versioning whatsoever.

And even if people need to downgrade their Poetry version for any reason, executing poetry lock will create a new lock file compatible with the current version so complete breakage of current projects is unlikely.

That being said, we will see if we can alleviate this in the next 1.0.6 bugfix release to make sure that downgrading is possible even though there is no guarantee there because the resolution logic has changed quite a bit on the develop branch so that might prove difficult.

@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

4 participants