Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests is poetry's sdist #1109

Closed
jayvdb opened this issue May 18, 2019 · 8 comments
Closed

Include tests is poetry's sdist #1109

jayvdb opened this issue May 18, 2019 · 8 comments

Comments

@jayvdb
Copy link

jayvdb commented May 18, 2019

I am starting the process of packaging poetry for openSUSE here, and notice that the sdist doesnt contain tests, and the GitHub archive doesnt contain setup.py . As a result, there is no single versioned tarball which can be used to build and test poetry. I need to unpack both to have a usable poetry for building a testable rpm.

The easiest way to solve this is to include the tests in the poetry sdist.

@eli-schwartz
Copy link

eli-schwartz commented May 27, 2019

I have just run into the same issue on Arch Linux, and this makes it difficult to package any software released using poetry (including poetry itself, and its dependencies that are also authored by @sdispater).

@eli-schwartz
Copy link

@jayvdb By the way, are you aware of the similar packaging issue in #866?

@jayvdb
Copy link
Author

jayvdb commented May 28, 2019

I wasn't aware of it. Thanks for the heads-up. Anyone looking to workaround some of these packaging problems with pyproject.toml projects , I found @dephell to work quite well, and the maintainer is very responsive .

@eli-schwartz
Copy link

Odd coincidence -- I'm actually attempting to package dephell as of yesterday. :p
Once that is done I am going to check out how feasible it is to add build-depends on python-dephell for poetry projects, and use dephell convert on the github sources (with testsuite) to generate a setup.py.

@sdispater
Copy link
Member

I plan on making the packages section of the pyproject.toml file support specifying the format for which the package should be included (no format meaning all of them).

[tool.poetry]
# ...
packages = [
    { include = "my_package" },
    { include = "tests", format = "sdist" },
]

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@stale
Copy link

stale bot commented Nov 20, 2019

Closing this issue automatically because it has not had any activity since it has been marked as stale. If you think it is still relevant and should be addressed, feel free to open a new one.

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants