installer: fix PATH when building a dependency from source (#8630)

Author: radoering

Diff for: src/poetry/installation/chef.py

@@ -129,10 +129,8 @@ def _prepare(
 
         with ephemeral_environment(self._env.python) as venv:
             env = IsolatedEnv(venv, self._pool)
-            builder = ProjectBuilder(
-                directory,
-                python_executable=env.python_executable,
-                runner=quiet_subprocess_runner,
+            builder = ProjectBuilder.from_isolated_env(
+                env, directory, runner=quiet_subprocess_runner
             )
             env.install(builder.build_system_requires)
 

Diff for: tests/fixtures/project_with_setup_calls_script/my_package/__init__.py

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["setuptools", "<scripts>"]
+build-backend = "setuptools.build_meta:__legacy__"

Diff for: tests/fixtures/project_with_setup_calls_script/pyproject.toml

@@ -0,0 +1,23 @@
+from __future__ import annotations
+
+import subprocess
+
+from setuptools import setup
+
+if subprocess.call(["exit-code"]) != 42:
+    raise RuntimeError("Wrong exit code.")
+
+kwargs = dict(
+    name="project-with-setup-calls-script",
+    license="MIT",
+    version="0.1.2",
+    description="Demo project.",
+    author="Sébastien Eustace",
+    author_email="[email protected]",
+    url="https://github.com/demo/demo",
+    packages=["my_package"],
+    install_requires=["pendulum>=1.4.4", "cachy[msgpack]>=0.2.0"],
+)
+
+
+setup(**kwargs)

Diff for: tests/fixtures/project_with_setup_calls_script/setup.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import os
+import shutil
 import sys
 import tempfile
 
@@ -10,6 +11,7 @@
 
 import pytest
 
+from build import ProjectBuilder
 from poetry.core.packages.utils.link import Link
 
 from poetry.factory import Factory
@@ -165,3 +167,49 @@ def test_prepare_directory_editable(
 
     # cleanup generated tmp dir artifact
     os.unlink(wheel)
+
+
+@pytest.mark.network
+def test_prepare_directory_script(
+    config: Config,
+    config_cache_dir: Path,
+    artifact_cache: ArtifactCache,
+    fixture_dir: FixtureDirGetter,
+    tmp_path: Path,
+    mocker: MockerFixture,
+) -> None:
+    """
+    Building a project that requires calling a script from its build_requires.
+    """
+    # make sure the scripts project is on the same drive (for Windows tests in CI)
+    scripts_dir = tmp_path / "scripts"
+    shutil.copytree(fixture_dir("scripts"), scripts_dir)
+
+    orig_build_system_requires = ProjectBuilder.build_system_requires
+
+    class CustomPropertyMock:
+        def __get__(
+            self, obj: ProjectBuilder, obj_type: type[ProjectBuilder] | None = None
+        ) -> set[str]:
+            assert isinstance(obj, ProjectBuilder)
+            return {
+                req.replace("<scripts>", f"scripts @ {scripts_dir.as_uri()}")
+                for req in orig_build_system_requires.fget(obj)  # type: ignore[attr-defined]
+            }
+
+    mocker.patch(
+        "build.ProjectBuilder.build_system_requires",
+        new_callable=CustomPropertyMock,
+    )
+    chef = Chef(
+        artifact_cache, EnvManager.get_system_env(), Factory.create_pool(config)
+    )
+    archive = fixture_dir("project_with_setup_calls_script").resolve()
+
+    wheel = chef.prepare(archive)
+
+    assert wheel.name == "project_with_setup_calls_script-0.1.2-py3-none-any.whl"
+
+    assert wheel.parent.parent == Path(tempfile.gettempdir())
+    # cleanup generated tmp dir artifact
+    os.unlink(wheel)