repo/legacy: remove unwanted stubbing of packages

This change removes a stubbing change added in 46ae4f5. This change
was incorrect, as the base class already sets package list to an
empty list.

The test case was also incorrect as it forced addition to internal
package list.

Author: abn

src/poetry/repositories/legacy_repository.py

@@ -38,18 +38,6 @@ def __init__(
 
         super().__init__(name, url.rstrip("/"), config, disable_cache, pool_size)
 
-    @property
-    def packages(self) -> list[Package]:
-        # LegacyRepository._packages is not populated and other implementations
-        # implicitly rely on this (e.g. Pool.search via
-        # LegacyRepository.search). To avoid special-casing Pool or changing
-        # behavior, we stub and return an empty list.
-        #
-        # TODO: Rethinking search behaviour and design.
-        # Ref: https://github.com/python-poetry/poetry/issues/2446 and
-        # https://github.com/python-poetry/poetry/pull/6669#discussion_r990874908.
-        return []
-
     def package(
         self, name: str, version: Version, extras: list[str] | None = None
     ) -> Package:

tests/repositories/test_legacy_repository.py

@@ -62,13 +62,6 @@ def _download(
         shutil.copyfile(str(filepath), dest)
 
 
-def test_packages_property_returns_empty_list() -> None:
-    repo = MockRepository()
-    repo._packages = [repo.package("jupyter", Version.parse("1.0.0"))]
-
-    assert repo.packages == []
-
-
 def test_page_relative_links_path_are_correct() -> None:
     repo = MockRepository()