Skip to content

Commit 38001dd

Browse files
committed
be nice to plugin authors
1 parent a0c85aa commit 38001dd

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

src/poetry/repositories/repository_pool.py

+12
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
from poetry.core.packages.dependency import Dependency
2121
from poetry.core.packages.package import Package
2222

23+
_SENTINEL = object()
24+
2325

2426
class Priority(IntEnum):
2527
# The order of the members below dictates the actual priority. The first member has
@@ -41,6 +43,7 @@ class RepositoryPool(AbstractRepository):
4143
def __init__(
4244
self,
4345
repositories: list[Repository] | None = None,
46+
ignore_repository_names: object = _SENTINEL,
4447
*,
4548
config: Config | None = None,
4649
) -> None:
@@ -56,6 +59,15 @@ def __init__(
5659
cache_dir=(config or Config.create()).artifacts_cache_directory
5760
)
5861

62+
if ignore_repository_names is not _SENTINEL:
63+
warnings.warn(
64+
"The 'ignore_repository_names' argument to 'RepositoryPool.__init__' is"
65+
" deprecated. It has no effect anymore and will be removed in a future"
66+
" version.",
67+
DeprecationWarning,
68+
stacklevel=2,
69+
)
70+
5971
@staticmethod
6072
def from_packages(packages: list[Package], config: Config | None) -> RepositoryPool:
6173
pool = RepositoryPool(config=config)

tests/repositories/test_repository_pool.py

+11
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ def test_repository_no_repository() -> None:
3838
pool.repository("foo")
3939

4040

41+
def test_repository_deprecated_ignore_repository_names() -> None:
42+
with pytest.warns(DeprecationWarning):
43+
RepositoryPool(ignore_repository_names=True)
44+
with pytest.warns(DeprecationWarning):
45+
RepositoryPool(ignore_repository_names=False)
46+
with pytest.warns(DeprecationWarning):
47+
RepositoryPool(None, True)
48+
with pytest.warns(DeprecationWarning):
49+
RepositoryPool(None, False)
50+
51+
4152
def test_adding_repositories_with_same_name_twice_raises_value_error() -> None:
4253
repo1 = Repository("repo")
4354
repo2 = Repository("repo")

0 commit comments

Comments
 (0)