simplify handling of extras

[dimbleby]

extras in this plug-in are never None, or True, or False: just a (possibly-empty) collection of strings

[neersighted]

I'd like to bring this in, but it's failing mypy -- PTAL.

[dimbleby]

poetry types are already changed upstream to match this, but until a new version is released, mypy will fail here

[neersighted]

Rebased on top of core 1.3.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.4% Duplication

[neersighted]

Wow, there's some fascinating failures happening -- back to you @dimbleby 😆

[dimbleby]

the reason for the failure is that in poetry 1.2.2 get_extra_package_names() returns an iterable, so the check that goes something like:

extra_package_names = get_extra_package_names()
for package in packages:
   if package in extra_package_names:
     ...

consumes the iterable as it goes and you might or might not be lucky when checking the second and subsequent packages.

On master, get_extra_package_names() returns a set and there is no problem.

Could patch this now with an explicit set(), or could wait for poetry 1.3 to be released. As usual, the circular dependency makes this more awkward than it ought to be...

[dimbleby]

rebased on #167 which I expect should allow the CI to pass

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.3% Duplication