Skip to content

Commit e414556

Browse files
author
rusty
committed
Resolve invalid python version constraint
1 parent 8d5e5c5 commit e414556

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

poetry/core/packages/dependency.py

+3
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ def to_pep_508(self, with_extras: bool = True) -> str:
276276
def _create_nested_marker(
277277
self, name: str, constraint: Union["BaseConstraint", "VersionTypes"]
278278
) -> str:
279+
from poetry.core.semver.empty_constraint import EmptyConstraint
279280
from poetry.core.semver.version import Version
280281
from poetry.core.semver.version_union import VersionUnion
281282

@@ -318,6 +319,8 @@ def _create_nested_marker(
318319
name = "python_full_version"
319320

320321
marker = '{} == "{}"'.format(name, constraint.text)
322+
elif isinstance(constraint, EmptyConstraint):
323+
marker = ""
321324
else:
322325
if constraint.min is not None:
323326
min_name = name

tests/packages/test_main.py

+9
Original file line numberDiff line numberDiff line change
@@ -272,3 +272,12 @@ def test_dependency_from_pep_508_should_not_produce_empty_constraints_for_correc
272272
str(dep.marker)
273273
== 'platform_python_implementation != "PyPy" and python_version <= "3.10" and python_version > "3"'
274274
)
275+
276+
277+
def test_dependency_from_pep_508_with_invalid_python_version_constraint():
278+
name = 'some-dependency ; python_version >= "3.6" and python_version <= "3.4"'
279+
dep = Dependency.create_from_pep_508(name)
280+
281+
assert dep.name == "some-dependency"
282+
assert str(dep.constraint) == "*"
283+
assert dep.python_versions == "*"

0 commit comments

Comments
 (0)