test that RECORD matches built wheel

Author: dimbleby

tests/masonry/builders/test_complete.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import csv
 import os
 import platform
 import re
@@ -89,12 +90,18 @@ def test_wheel_c_extension() -> None:
             is not None
         )
 
-        records = zip.read("extended-0.1.dist-info/RECORD").decode()
+        record = zip.read("extended-0.1.dist-info/RECORD").decode()
+        records = csv.reader(record.splitlines())
+        record_files = [row[0] for row in records]
 
-        assert re.search(r"\s+extended/extended.*\.(so|pyd)", records) is not None
+        assert re.search(r"\s+extended/extended.*\.(so|pyd)", record) is not None
     finally:
         zip.close()
 
+    # Files in RECORD should match files in wheel.
+    zip_files = sorted(zip.namelist())
+    assert zip_files == sorted(record_files)
+
 
 @pytest.mark.skipif(
     sys.platform == "win32"
@@ -144,12 +151,18 @@ def test_wheel_c_extension_with_no_setup() -> None:
             is not None
         )
 
-        records = zip.read("extended-0.1.dist-info/RECORD").decode()
+        record = zip.read("extended-0.1.dist-info/RECORD").decode()
+        records = csv.reader(record.splitlines())
+        record_files = [row[0] for row in records]
 
-        assert re.search(r"\s+extended/extended.*\.(so|pyd)", records) is not None
+        assert re.search(r"\s+extended/extended.*\.(so|pyd)", record) is not None
     finally:
         zip.close()
 
+    # Files in RECORD should match files in wheel.
+    zip_files = sorted(zip.namelist())
+    assert zip_files == sorted(record_files)
+
 
 @pytest.mark.skipif(
     sys.platform == "win32"
@@ -199,12 +212,18 @@ def test_wheel_c_extension_src_layout() -> None:
             is not None
         )
 
-        records = zip.read("extended-0.1.dist-info/RECORD").decode()
+        record = zip.read("extended-0.1.dist-info/RECORD").decode()
+        records = csv.reader(record.splitlines())
+        record_files = [row[0] for row in records]
 
-        assert re.search(r"\s+extended/extended.*\.(so|pyd)", records) is not None
+        assert re.search(r"\s+extended/extended.*\.(so|pyd)", record) is not None
     finally:
         zip.close()
 
+    # Files in RECORD should match files in wheel.
+    zip_files = sorted(zip.namelist())
+    assert zip_files == sorted(record_files)
+
 
 def test_complete() -> None:
     module_path = fixtures_dir / "complete"
@@ -297,20 +316,23 @@ def test_complete() -> None:
         # vary per operating systems and Python versions.
         # So instead of 1:1 assertion, let's do a bit clunkier one:
 
-        expected_records = [
+        actual_files = [row[0] for row in csv.reader(actual_records.splitlines())]
+        expected_files = [
+            "my_package-1.2.3.data/scripts/script.sh",
+            "my_package-1.2.3.dist-info/LICENSE",
+            "my_package-1.2.3.dist-info/METADATA",
+            "my_package-1.2.3.dist-info/RECORD",
+            "my_package-1.2.3.dist-info/WHEEL",
+            "my_package-1.2.3.dist-info/entry_points.txt",
             "my_package/__init__.py",
             "my_package/data1/test.json",
             "my_package/sub_pkg1/__init__.py",
             "my_package/sub_pkg2/__init__.py",
             "my_package/sub_pkg2/data2/data.json",
-            "my_package-1.2.3.dist-info/entry_points.txt",
-            "my_package-1.2.3.dist-info/LICENSE",
-            "my_package-1.2.3.dist-info/WHEEL",
-            "my_package-1.2.3.dist-info/METADATA",
+            "my_package/sub_pkg3/foo.py"
         ]
 
-        for expected_record in expected_records:
-            assert expected_record in actual_records
+        assert sorted(expected_files) == sorted(actual_files)
 
     finally:
         zip.close()