Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: remove dependency on system provided pip #61

Closed
abn opened this issue Mar 27, 2021 · 2 comments
Closed

bootstrap: remove dependency on system provided pip #61

abn opened this issue Mar 27, 2021 · 2 comments

Comments

@abn
Copy link
Member

abn commented Mar 27, 2021

We should do a check for pip, as pip is not always present. If it's not present we have one of two options.

  1. Automatically execute python -m ensurepip.
  2. Error out, instructing user to install pip and hint at 1, since they may want to use distro specific installation.

Alternatively, virtualenv wheel should be usable without installation I think. That would make a cleaner approach.

  1. Download latest wheel.
  2. Insert wheel to site.
  3. Execute required commands.

Originally posted by @abn in python-poetry/poetry#3706 (comment)

@matangover
Copy link

I also encountered this but I initially couldn't find it in the issue tracker. Here is the error I got, in case it helps someone find this:

$ curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py | python3 -
[...]
Installing Poetry (1.1.6): Creating environment
Traceback (most recent call last):
  File "<stdin>", line 831, in <module>
  File "<stdin>", line 827, in main
  File "<stdin>", line 440, in run
  File "<stdin>", line 462, in install
  File "<stdin>", line 526, in make_env
ModuleNotFoundError: No module named 'virtualenv'

Note: This happens by default on Ubuntu where the python3 package does not come with pip.

@neersighted
Copy link
Member

This is now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants