Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python_full_version marker conversion to constraint #86

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Sep 25, 2020

I stumbled upon this one when trying to update poetry-core.

Basically, we would get the following error:

  SolverProblemError

  The current project's Python requirement (>=2.7,<2.8 || >=3.5,<4.0) is not compatible with some of the required packages Python requirement:
    - pre-commit requires Python >=3.6.1, so it will not be satisfied for Python >=2.7,<2.8 || >=3.5,<3.6.1

The root cause was that get_python_constraint_from_marker() was generating empty constraints for python_full_version markers since we were only checking python_version markers.

Resolves: python-poetry/poetry#2950

@sdispater sdispater requested a review from a team September 25, 2020 12:53
@abn abn merged commit 24f3577 into master Sep 25, 2020
@abn abn deleted the fix-of-python-full-version-marker-conversion branch September 25, 2020 13:25
@sdispater sdispater mentioned this pull request Sep 25, 2020
@abn abn added the Bug Something isn't working label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.1.0b3: Regression in handling python version constraints when running add/update
2 participants