Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url dependencies in multiple constraints dependencies #32

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

sdispater
Copy link
Member

Resolves: python-poetry/poetry#2033

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR is just a port of the following PR made on the main Poetry project: python-poetry/poetry#2035

Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor recommendation

poetry/core/json/schemas/poetry-schema.json Outdated Show resolved Hide resolved
@sdispater sdispater force-pushed the multi-constraints-url-dependencies branch from 6f6c7c0 to 009ef6b Compare May 31, 2020 15:56
@sdispater sdispater requested a review from abn June 2, 2020 07:57
@sdispater sdispater merged commit ea84097 into master Jun 5, 2020
@sdispater sdispater deleted the multi-constraints-url-dependencies branch June 5, 2020 15:12
@sdispater sdispater mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

url-dependency is missing from multiple-constraints-dependency
2 participants