Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git dependencies #30

Merged
merged 9 commits into from
May 10, 2020
Merged

Fix git dependencies #30

merged 9 commits into from
May 10, 2020

Conversation

simonepri
Copy link

@simonepri simonepri commented Apr 25, 2020

Resolves: python-poetry/poetry#2326, huggingface/transformers#3982

  • Added tests for changed code.
  • Updated documentation for changed code.

@simonepri simonepri marked this pull request as draft April 25, 2020 17:46
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

poetry/core/utils/helpers.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/packages/test_main.py Show resolved Hide resolved
poetry/core/packages/__init__.py Show resolved Hide resolved
poetry/core/utils/helpers.py Outdated Show resolved Hide resolved
@simonepri simonepri requested a review from abn April 26, 2020 13:16
@simonepri
Copy link
Author

@abn Any update on this?

@abn
Copy link
Member

abn commented Apr 29, 2020

I will get to this one this week hopefully. I wanted to go through the relevant peps before getting back to you.

@tholiao
Copy link

tholiao commented Apr 29, 2020

This PR fixes an issue involving a widely used library for natural language processing; there are two major conference deadlines in a month so any expedition would be greatly, greatly appreciated!

@simonepri
Copy link
Author

@abn Sorry for pinging you again.
Do we have any blocker for this?

@abn abn merged commit 871ad9b into python-poetry:master May 10, 2020
@sdispater sdispater mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InvalidRequirement] Invalid requirement, parse error at "'extra =='"
3 participants