Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for PEP-440 direct references #22

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

abn
Copy link
Member

@abn abn commented Apr 12, 2020

With this change we allow for PEP-508 string for file dependencies
to use PEP-440 direct reference using the file URI scheme (RFC-8089).

Note that this implementation will not allow non RFC-8089 file path
references. In order to allow for sdist to be portable in sane use
cases, we ensure that relative path dependencies do not use the
file URI scheme, but preserve path if relative or directories.

In addition to file resource, directory dependencies now support
the same scheme.

References:

@abn abn force-pushed the file-uri-scheme branch 3 times, most recently from 2313b1b to 1687fb9 Compare April 12, 2020 16:01
@abn abn marked this pull request as draft April 12, 2020 16:04
@abn abn force-pushed the file-uri-scheme branch 7 times, most recently from 145d9a2 to 28a02ba Compare April 16, 2020 01:09
@abn abn marked this pull request as ready for review April 16, 2020 01:14
@abn abn requested a review from sdispater April 16, 2020 01:15
With this change we allow for PEP-508 string for file dependencies
to use PEP-440 direct reference using the file URI scheme (RFC-8089).

Note that this implementation will not allow non RFC-8089 file path
references. In order to allow for sdist to be portable in sane use
cases, we ensure that relative path dependencies do not use the
file URI scheme, but preserve path if relative or directories.

In addition to file resource, directory dependencies now support
the same scheme.

References:
- https://www.python.org/dev/peps/pep-0508/#backwards-compatibility
- https://www.python.org/dev/peps/pep-0440/#direct-references
- https://tools.ietf.org/html/rfc8089
- https://discuss.python.org/t/what-is-the-correct-interpretation-of-path-based-pep-508-uri-reference/2815/11
@abn abn merged commit 6d0f8fd into python-poetry:master Apr 21, 2020
@sdispater sdispater mentioned this pull request Apr 24, 2020
@abn abn deleted the file-uri-scheme branch July 27, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants