-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.4? #3581
Comments
For comparison, Python 3.3 was EOL on 2017-09-29 and was dropped on 2018-01-01 (#2832) because pytest no longer supported it. We didn't drop it on 2017-10-01 as there weren't as big gains (#2725) compared to 2.6/3.2. Pip 19.0 is due out in a couple of days (pypa/pip#6106) and deprecates support for Python 3.4 (pypa/pip#6123). Pip 19.2 is due out in 2019-07 (pypa/pip#5324) and will drop it. Here's the pip installs for Pillow for the past 3 years: For December 2018:
Source: By OS, and limiting to 3.4:
Source: |
@python-pillow/pillow-team: Feedback welcome! |
@hugovk LGTM. As a general rule "we don't support releases not supported Python Core Team" seems reasonable. It helps, in this case, that no one is using Pillow on 3.4 (if I'm reading your stats correctly at a glance.) If there were more usage, for example, I might be inclined to try to support longer. |
VERSION deprecationAdded in PR #3090, released in 5.2.0 on 2018-07-01, # VERSION is deprecated and will be removed in Pillow 6.0.0.
# PILLOW_VERSION is deprecated and will be removed after that.
# Use __version__ instead.
VERSION = '1.1.7' # PIL Version
PILLOW_VERSION = __version__ = _version.__version__ Also in release notes: And recently added on this new page: 6.0.0 will be out 9 months after 5.2.0. Shall we press ahead and remove Or give it some more time and postpone it to 7.0.0? |
The static |
Python 3.4 reaches EOL on 2019-03-16 and is no longer supported by the core Python team.
I propose the 2019-04-01 release (or another TBD) should be major release 6.0.0 and we also bundle in some deprecation warning removals at the same time.
Drop Python 3.4
From the deprecations page, but only if deprecated for a year (per Release Pillow 3.0 after 2.9? #1087 (comment)):
Remove deprecated (since 4.0.0/2017-01) PIL.OleFileIO in favour of olefile Python package (Remove vendored version of olefile Python package in favor of upstream #2199, Remove deprecated PIL.OleFileIO in favour of olefile Python package #2784)
Remove deprecated (4.3.0/2017-10) ImageOps undocumented functions (Deprecate ImageOps undocumented functions #2735)
Remove deprecated (5.2.0/2018-07)
PILLOW_VERSION
andVERSION
( Deprecate PILLOW_VERSION and VERSION #3090)Remove deprecated (5.3.0/2018-10) setting of TIFF image sizes, make read-only (Changed Image size property to be read-only by default #3203)(<1 year)Docs and release notes: Document removals #3600
Anything else?
Thoughts, objections, additions?
If 2019-04-01 is too early, when would be a suitable time?
The text was updated successfully, but these errors were encountered: