Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baby anaconda to snake hatch #822

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Add baby anaconda to snake hatch #822

merged 5 commits into from
Aug 30, 2021

Conversation

KittyBorgX
Copy link
Contributor

Details : #821

Relevant Issues

Closes #821

Description

The snake was added in the _utils file and is implemented through a linking of a igmur image

Did you:

ventaquil
ventaquil requested changes Aug 27, 2021
View reviewed changes
Copy link
Member

@ventaquil ventaquil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot we add comma at the end to just add lines next time instead of editing it?

bot/exts/evergreen/snakes/_utils.py Outdated Show resolved Hide resolved
@KittyBorgX @ventaquil
Update bot/exts/evergreen/snakes/_utils.py
86899bd 
Add a comma

Co-authored-by: kgolawski <[email protected]>
@KittyBorgX
Copy link
Contributor Author

Done

@KittyBorgX
Copy link
Contributor Author

can i close this pr ?

@KittyBorgX KittyBorgX closed this Aug 28, 2021
@KittyBorgX KittyBorgX reopened this Aug 28, 2021
ventaquil
ventaquil approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@ventaquil ventaquil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for me but it looks that some hooks failed.

@KittyBorgX
Copy link
Contributor Author

I ran the linting tho and its a 1 line change afterall 🤔

@wookie184
Copy link
Contributor

wookie184 commented Aug 28, 2021 •
edited
Loading

Looks like the problem is that the "baby cobra" line now has trailing whitespace, if you have the linting set up correctly it should detect that, have you run poetry run task precommit (and then poetry run task lint if you want to run it explicitly)?

@KittyBorgX
Copy link
Contributor Author

Linting process have been completed and i've fixed that from my end

Bluenix2
Bluenix2 requested changes Aug 29, 2021
View reviewed changes
bot/exts/evergreen/snakes/_utils.py Outdated Show resolved Hide resolved
@KittyBorgX
Copy link
Contributor Author

I've added the anaconda logo and here's the preview :
image

@KittyBorgX KittyBorgX requested a review from Bluenix2 August 30, 2021 05:53
wookie184
wookie184 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me 👍

ChrisLovering
ChrisLovering approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@ChrisLovering ChrisLovering merged commit 6c63e3c into python-discord:main Aug 30, 2021
@KittyBorgX
Copy link
Contributor Author

Tysm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wookie184 wookie184 wookie184 approved these changes

@ventaquil ventaquil ventaquil approved these changes

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@Bluenix2 Bluenix2 Awaiting requested review from Bluenix2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add anaconda snake to the snake hatch command
5 participants
@KittyBorgX @wookie184 @ChrisLovering @ventaquil @Bluenix2