Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of generators #70

Open
vcokltfre opened this issue Oct 17, 2021 · 2 comments
Open

Change return type of generators #70

vcokltfre opened this issue Oct 17, 2021 · 2 comments

Comments

@vcokltfre
Copy link
Contributor

vcokltfre commented Oct 17, 2021

This proposes that the return type of generation endpoints be changed to return objects in the structure of:

{
  "seed": 1234,
  "url": "https://..."
}

This would mean that applications are able to access the seed by which a ducky is generated, if it's randomly generated (although this would be included for consistency on seeded ducks too).

Note that this format (returning a URL) relies on quackstack being made to use S3 compatible object storage before it can be implemented.

@Akarys42
Copy link
Contributor

Akarys42 commented Oct 17, 2021

How would we feel about returning the seed as a header instead so hotlinking the generation endpoint is still possible?

@vcokltfre
Copy link
Contributor Author

[Discussed in discord] The endpoint already returns a JSON object so that's a non-concern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants