From ae4a8bfa92b61fca3c7215db1116df4b525a2fa1 Mon Sep 17 00:00:00 2001 From: Nathan Goldbaum Date: Mon, 25 Aug 2025 14:54:12 -0600 Subject: [PATCH 1/3] enable windows pytest-run-parallel CI --- .github/workflows/ci.yaml | 6 ------ testing/cffi1/test_function_args.py | 5 +++++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e91e720d..6d448b74 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -429,12 +429,6 @@ jobs: python -m pip install . - name: run tests under pytest-run-parallel - if: runner.os == 'Windows' - run: | - python -m pytest --parallel-threads=4 src/c - - - name: run tests under pytest-run-parallel - if: runner.os != 'Windows' run: | python -m pytest --parallel-threads=4 diff --git a/testing/cffi1/test_function_args.py b/testing/cffi1/test_function_args.py index 30c6feda..4e7e8c3b 100644 --- a/testing/cffi1/test_function_args.py +++ b/testing/cffi1/test_function_args.py @@ -1,4 +1,9 @@ import pytest, sys + +pytestmark = [ + pytest.mark.thread_unsafe(reason="Workers would share a build directory"), +] + try: # comment out the following line to run this test. # the latest on x86-64 linux: https://github.com/libffi/libffi/issues/574 From fbb6c8a9dd99940a72b0cb210437afa31bba14fa Mon Sep 17 00:00:00 2001 From: Nathan Goldbaum Date: Mon, 25 Aug 2025 15:00:14 -0600 Subject: [PATCH 2/3] pass skip-thread-unsafe --- .github/workflows/ci.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6d448b74..11fb8755 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -429,6 +429,12 @@ jobs: python -m pip install . - name: run tests under pytest-run-parallel + if: runner.os == 'Windows' + run: | + python -m pytest --parallel-threads=4 --skip-thread-unsafe=True + + - name: run tests under pytest-run-parallel + if: runner.os != 'Windows' run: | python -m pytest --parallel-threads=4 From bf014432b8e1a96c8ad5551e5a8f091a92fcb0a8 Mon Sep 17 00:00:00 2001 From: Nathan Goldbaum Date: Mon, 25 Aug 2025 15:10:11 -0600 Subject: [PATCH 3/3] remove OS conditional --- .github/workflows/ci.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 11fb8755..64c5199f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -429,15 +429,9 @@ jobs: python -m pip install . - name: run tests under pytest-run-parallel - if: runner.os == 'Windows' run: | python -m pytest --parallel-threads=4 --skip-thread-unsafe=True - - name: run tests under pytest-run-parallel - if: runner.os != 'Windows' - run: | - python -m pytest --parallel-threads=4 - clang_TSAN: runs-on: ubuntu-latest container: ghcr.io/nascheme/numpy-tsan:3.14t