Improve GitHub release workflow #11754
Conversation
nicoddemus
force-pushed
the
release-notes
branch
2 times, most recently
from
f4718f4 to
23b6a90
Compare
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| body_path: scripts/latest-release-notes.md | ||
| files: dist/* |
There was a problem hiding this comment.
What does this line do (what is in dist/)?
There was a problem hiding this comment.
The sdist and wheel generated by the hynek/[email protected] action.
There was a problem hiding this comment.
Any particular reason to have these artifacts in github? My instincts tell me it's better to have one source of truth (PyPI).
There was a problem hiding this comment.
I think it is standard practice, many other plugins follow the same approach.
Note we are publishing exactly the same files that we upload to PyPI, I particularly like it.
There was a problem hiding this comment.
I am still somewhat interested to know why someone would want to download the wheel/sdist from github instead of pypi, but OK :)
There was a problem hiding this comment.
Distro packagers do strange things
There was a problem hiding this comment.
I find it neat to have the sdist/wheel in the GitHub release page -- given it is the exact same package as PyPI I don't see problems with it. 😁
nicoddemus
force-pushed
the
release-notes
branch
from
23b6a90 to
daf12b2
Compare
nicoddemus
added
the
needs backport
This changes the existing script to just generate the release notes and delegate the actual publishing to the `softprops/action-gh-release@v1` action. This allows us to delete the custom code, which failed recently in https://github.com/pytest-dev/pytest/actions/runs/7370258570/job/20056477756.
nicoddemus
force-pushed
the
release-notes
branch
from
daf12b2 to
6321b74
Compare
nicoddemus
added
backport 8.0.x
and removed
needs backport
Follow up to pytest-dev#11754, noticed that the latest GitHub release does not contain the attached files. Output log from the action: ``` 🤔 Pattern 'dist/*' does not match any files. ```
Follow up to #11754, noticed that the latest GitHub release does not contain the attached files. Output log from the action: ``` 🤔 Pattern 'dist/*' does not match any files. ```
Follow up to pytest-dev#11754, noticed that the latest GitHub release does not contain the attached files. Output log from the action: ``` 🤔 Pattern 'dist/*' does not match any files. ```
This changes the existing script to just generate the release notes and delegate the actual publishing to the
softprops/action-gh-release@v1action.This allows us to delete the custom code, which failed recently in https://github.com/pytest-dev/pytest/actions/runs/7370258570/job/20056477756.
In addition, the 2nd commit enables type checking in
scripts/for additional safety.I will remove the secrets that are no longer needed from the repository after this is merged.