Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --fold-skipped=yes|no cli option #12567

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

pbrezina
Copy link
Contributor

@pbrezina pbrezina commented Jul 3, 2024

This controlls how the skipped tests are displayed in the short summary.

  • yes (default): keeps the current behavior that folds the skipped tests
    together
  • no: each skipped test is on its own line, display as any other status

Resolves: #9876

@pbrezina pbrezina marked this pull request as draft July 3, 2024 12:58
@pbrezina
Copy link
Contributor Author

pbrezina commented Jul 3, 2024

Please, let me know if you'd accept this change. If yes, I will include tests and documentation.

@nicoddemus

@webknjaz webknjaz requested a review from nicoddemus July 3, 2024 13:30
@nicoddemus
Copy link
Member

nicoddemus commented Jul 3, 2024

Thanks @pbrezina!

I think it is reasonable, @The-Compiler @bluetech @RonnyPfannschmidt any objections?

src/_pytest/terminal.py Outdated Show resolved Hide resolved
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jul 4, 2024
@pbrezina pbrezina marked this pull request as ready for review July 4, 2024 11:45
@pbrezina
Copy link
Contributor Author

pbrezina commented Jul 4, 2024

Thank you. I added test, docs and changed option to --no-fold-skipped.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pbrezina!

LGTM, left a minor suggestion.

doc/en/how-to/output.rst Outdated Show resolved Hide resolved
This controlls how the skipped tests are display in the short summary.

- yes (default): keeps the current behavior that folds the skipped tests
  together
- no: each skipped test is on its own line, display as any other status

Resolves: pytest-dev#9876
Signed-off-by: Pavel Březina <[email protected]>
@nicoddemus
Copy link
Member

@RonnyPfannschmidt would you like to take another look before we squash/merge?

@nicoddemus nicoddemus merged commit cf5369d into pytest-dev:main Jul 5, 2024
29 checks passed
@nicoddemus
Copy link
Member

Thanks @pbrezina!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: revisit folding skipped tests in summary
3 participants