-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Support venv detection on Windows with mingw Python #12545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs need to be updated too: https://github.com/pytest-dev/pytest/blob/main/doc/en/reference/reference.rst?plain=1#L1705-L1706
I'd guess just removing the " by the presence of an activation script" should be enough. The users shouldn't need to care how it's done.
Otherwise lgtm, code wise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zachsnicker, and @lazka for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited this entry a little, in #12559. Preview: https://pytest--12559.org.readthedocs.build/en/12559/changelog.html#improvements-in-existing-functionality.
Seems like this is basically breaking pytest support in conda environments, can we revert this change until we've reliably roll out |
@jezdez is there a good way to check for conda prior to that change? im happy to roll back for now, but if a consistent bugfix that ensures compatibility with older conda is easy, i'd prefer landing that over a revert dance |
Actually, apologies for responding to a closed PR, can we move that into #12652 please? |
closes #12544
_in_venv
function insrc/_pytest/main.py
to correctly detect Python virtual environments.testing/test_collection.py
to validate the new behavior.