📝💅 Always render changelog draft @ Sphinx docs #12493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RonnyPfannschmidt let's label this as a backport and skip news? |
webknjaz
force-pushed
the
maintenance/sphinx-towncrier-draft
branch
from
0aee63d
to
467c47a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
webknjaz
force-pushed
the
maintenance/sphinx-towncrier-draft
branch
2 times, most recently
from
971c17a
to
c2f5c8f
Compare
RonnyPfannschmidt
added
skip news
RonnyPfannschmidt
approved these changes
Jun 20, 2024
The earlier implementation was generating a temporary file, when the docs site was being built with `tox`. However, this was not enabled in RTD and is hackish. This patch integrates the `sphinxcontrib-towncrier` extension to make it work in any environment where Sphinx docs are being built.
auto-merge was automatically disabled
June 20, 2024 08:44
Head branch was pushed to by a user without write access
webknjaz
force-pushed
the
maintenance/sphinx-towncrier-draft
branch
from
c2f5c8f
to
e702079
Compare
Backport to 8.2.x: 💚 backport PR created✅ Backport PR branch: Backported as #12495 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
…draft 📝💅 Always render changelog draft @ Sphinx docs (cherry picked from commit 20dd1d6)
RonnyPfannschmidt
added a commit
that referenced
this pull request
Jun 20, 2024
…0dd1d6738d0623fe3176e796805bbd6e36cf831/pr-12493 [PR #12493/20dd1d67 backport][8.2.x] 📝💅 Always render changelog draft @ Sphinx docs
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
It is called when building the docs. Apparently, `tox -e docs` is not invoked in CI, neither is it called in RTD, resulting in the regression having been caught only in local development environments. This is a follow-up for pytest-dev#12493.
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
It is uncapped in RTD. Apparently, `tox -e docs` is not invoked in CI, neither is it called in RTD, resulting in the regression having been caught only in local development environments. This is a follow-up for pytest-dev#12493.
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
It is called when building the docs. Apparently, `tox -e docs` is not invoked in CI, neither is it called in RTD, resulting in the regression having been caught only in local development environments. This is a follow-up for pytest-dev#12493.
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
It is uncapped in RTD. Apparently, `tox -e docs` is not invoked in CI, neither is it called in RTD, resulting in the regression having been caught only in local development environments. This is a follow-up for pytest-dev#12493.
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 21, 2024
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 21, 2024
RonnyPfannschmidt
added a commit
that referenced
this pull request
Jun 21, 2024
…inx-towncrier-draft 📝 Add a change note for PR #12493
webknjaz
added
the
type: infrastructure
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier implementation was generating a temporary file, when the docs site was being built with
tox. However, this was not enabled in RTD and is hackish.This patch integrates the
sphinxcontrib-towncrierextension to make it work in any environment where Sphinx docs are being built.📝 Preview/demo: https://pytest--12493.org.readthedocs.build/en/12493/changelog.html#to-be-included-in-vrelease-if-present