Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pytest 8.4 compatibility #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pytest 8.4 compatibility #233

wants to merge 1 commit into from
+22 −8

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Jan 11, 2025 •
edited
Loading

Fix #232

Checklist:

  • To be released only once pytest 8.4 is released and the fix is confirmed to work.

@youtux youtux force-pushed the ab/fix-pytest8.4-compat branch from 85c1776 to 1d468a0 Compare January 11, 2025 23:29
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (ca52a05) to head (15cd119).

Files with missing lines Patch % Lines
pytest_factoryboy/compat.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          14       14           
  Lines         851      852    +1     
  Branches       51       51           
=======================================
+ Hits          832      833    +1     
  Misses          8        8           
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youtux youtux requested a review from Copilot January 11, 2025 23:31
Copilot
Copilot AI reviewed Jan 11, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
@youtux youtux force-pushed the ab/fix-pytest8.4-compat branch from 1d468a0 to 15cd119 Compare January 11, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix compatibility with pytest >= 8.4
1 participant
@youtux