-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did not really dropped python 2.7 #487
Comments
pyupgrade would be good |
Looking at the code itself, it does not look like there is much to do. But on the dependency side, it could be more complicated. |
I think it's a matter of CI really. Whoever wants to overhaul the CI to use github actions or whatever can drop 2.7 as well (afaik running 2.7 on github actions is very unpleasant). |
I am sorry I had a look into it but got busy otherwise. I think you should also drop six. A single function from it is used ! diff --git a/setup.py b/setup.py
index c345f56..a2103f0 100755
--- a/setup.py
+++ b/setup.py
@@ -131,7 +131,6 @@ setup(
'fields',
'hunter',
'process-tests',
- 'six',
'pytest-xdist',
'virtualenv',
]
diff --git a/tests/test_pytest_cov.py b/tests/test_pytest_cov.py
index 0d1b5a2..edb4801 100644
--- a/tests/test_pytest_cov.py
+++ b/tests/test_pytest_cov.py
@@ -16,7 +16,6 @@ from fields import Namespace
from process_tests import TestProcess as _TestProcess
from process_tests import dump_on_error
from process_tests import wait_for_strings
-from six import exec_
import pytest_cov.plugin
@@ -1964,7 +1963,7 @@ def test_pth_failure(monkeypatch):
monkeypatch.setattr(embed, 'init', bad_init)
monkeypatch.setattr(sys, 'stderr', buff)
monkeypatch.setitem(os.environ, 'COV_CORE_SOURCE', 'foobar')
- exec_(payload)
+ exec(payload)
assert buff.getvalue() == '''pytest-cov: Failed to setup subprocess coverage. Environ: {'COV_CORE_SOURCE': 'foobar'} Exception: SpecificError()
'''
But, if your plan to only do this while migrating to github actions, then I am really not familiar with it, so I am not sure I can help. |
Summary
In PR #413 a mere comment was added to tell python 2.7 is no longer supported. But no actual code change was made.
Not even in the setup.py which still suggest python 2.7 is indeed supported.
Expected vs actual result
n/a
Reproducer
n/a
Versions
2.12.1
Config
n/a
Code
n/a
The text was updated successfully, but these errors were encountered: