Verify result of biject_to satisfies the constraint.
#1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
approved these changes
Mar 29, 2024
Member
fehiepsi
left a comment
fehiepsi
left a comment
There was a problem hiding this comment.
Thanks, @tillahoffmann! while you are on this transform test, could you also change the global jax arrays in this file to numpy arrays? We don't want to execute jax code before setting global information like platform or precision.
fehiepsi
reviewed
Apr 12, 2024
| (constraints.circular, (3,)), | ||
| (constraints.complex, (3,)), | ||
| (constraints.corr_cholesky, (10, 10)), | ||
| (constraints.corr_matrix, (21,)), |
Member
There was a problem hiding this comment.
@tillahoffmann This test is failing in my system with jax dev. Could we relax this to 15 (which passes)?
Collaborator
Author
There was a problem hiding this comment.
Sounds good. I can send a mini PR or integrate it into #1538?
Member
There was a problem hiding this comment.
Either of them sounds good to me. Thanks, Till!
OlaRonning
pushed a commit
to aleatory-science/numpyro
that referenced
this pull request
May 6, 2024
* Verify result of `biject_to` satisfies the constraint. * Replace global `jax.numpy` arrays by `numpy` arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1751, this PR adds a test that the result of calling
biject_tosatisfies the desired constraint. It also updates the correlation matrix constraint to reduce sensitivity to numerical errors. cc @kylejcaron