From 46420fbe131c4925a92107daf780775764b84e2b Mon Sep 17 00:00:00 2001 From: Nicole Harris Date: Mon, 2 Sep 2019 07:01:40 +0100 Subject: [PATCH] Ensure tables scale regardless of text size or length --- warehouse/static/js/warehouse/index.js | 8 +- .../static/sass/blocks/_breadcrumbs.scss | 14 +- warehouse/static/sass/blocks/_button.scss | 1 + .../sass/blocks/_project-description.scss | 38 +- warehouse/static/sass/blocks/_table.scss | 690 ++++-------------- .../static/sass/tools/_design-utilities.scss | 42 -- warehouse/templates/includes/hash-modal.html | 32 +- warehouse/templates/manage/account.html | 47 +- warehouse/templates/manage/history.html | 12 +- warehouse/templates/manage/journal.html | 7 +- warehouse/templates/manage/release.html | 36 +- warehouse/templates/manage/releases.html | 19 +- warehouse/templates/manage/roles.html | 22 +- warehouse/templates/packaging/detail.html | 22 +- 14 files changed, 318 insertions(+), 672 deletions(-) diff --git a/warehouse/static/js/warehouse/index.js b/warehouse/static/js/warehouse/index.js index 0c005806bc53..4eb8c8af32e4 100644 --- a/warehouse/static/js/warehouse/index.js +++ b/warehouse/static/js/warehouse/index.js @@ -143,18 +143,18 @@ docReady(() => { }); docReady(() => { - let changeRoleForms = document.querySelectorAll("form.change-role"); + let changeRoleForms = document.querySelectorAll("form.table__change-role"); if (changeRoleForms) { for (let form of changeRoleForms) { - let changeButton = form.querySelector("button.change-button"); - let changeSelect = form.querySelector("select.change-field"); + let changeButton = form.querySelector("button.table__change-button"); + let changeSelect = form.querySelector("select.table__change-field"); changeSelect.addEventListener("change", function (event) { if (event.target.value === changeSelect.dataset.original) { changeButton.style.display = "none"; } else { - changeButton.style.display = "inline-block"; + changeButton.style.display = "block"; } }); } diff --git a/warehouse/static/sass/blocks/_breadcrumbs.scss b/warehouse/static/sass/blocks/_breadcrumbs.scss index 76b5f008b0f8..570e4f221462 100644 --- a/warehouse/static/sass/blocks/_breadcrumbs.scss +++ b/warehouse/static/sass/blocks/_breadcrumbs.scss @@ -15,8 +15,8 @@ /* Navigation breadcrumbs. -