Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP-0691 format query parameter does not remain after redirect #11703

Open
Wouterkoorn opened this issue Jun 27, 2022 · 2 comments
Open

PEP-0691 format query parameter does not remain after redirect #11703

Wouterkoorn opened this issue Jun 27, 2022 · 2 comments
Labels
blocked Issues we can't or shouldn't get to yet bug 🐛

Comments

@Wouterkoorn
Copy link

The current implementation of PEP-0691 gives some unfriendly redirect behavior when browsing with the format query parameter. If you omit the trailing slash, it redirects without keeping the query parameter.

https://pypi.org/simple/pip redirects to https://pypi.org/simple/pip/
https://pypi.org/simple/pip?format=application/vnd.pypi.simple.v1+json does not redirect to https://pypi.org/simple/pip/?format=application/vnd.pypi.simple.v1+json

Although it might not be a standardized requirement, it is friendly to have.

@Wouterkoorn Wouterkoorn added bug 🐛 requires triaging maintainers need to do initial inspection of issue labels Jun 27, 2022
@dstufft
Copy link
Member

dstufft commented Jun 27, 2022

This will be because we strip the format parameter from the request at the edge, and translate it into an Accept header.

It's probably dependent on #11558

@di di removed the requires triaging maintainers need to do initial inspection of issue label Jun 28, 2022
@di
Copy link
Member

di commented Aug 12, 2022

Marking this as blocked on #11558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues we can't or shouldn't get to yet bug 🐛
Projects
None yet
Development

No branches or pull requests

3 participants