Skip to content

Conversation

@di
Copy link
Member

@di di commented Mar 23, 2020

This PR moves the canonical source for classifiers out of PyPI's database and into the trove-classifiers project.

This is a necessary step to resolve pypa/packaging#147 and move PyPI's metadata validation out of PyPI and into packaging.

PyPI's behavior here for the end user remains unchanged. For administrators, new & deprecated classifiers are no longer created through the UI, but as pull requests for trove-classifiers and dependency upgrades here.

PyPI still retains a Classifier model to help with efficiently searching for projects based on classifiers, but it is now essentially just a mapping from the classifier name to id. New rows in the classifiers table are created for new classifiers the first time a project is uploaded using that classifier.

Fixes #4626, fixes #3786, closes #4950, closes #1244.

@di di requested a review from ewdurbin March 23, 2020 23:49
@pradyunsg
Copy link
Contributor

Hey @di, are we waiting on reviews from @ewdurbin and possibly others here?

@di
Copy link
Member Author

di commented Apr 2, 2020

Need to merge/release pypa/trove-classifiers#6 and update this here first, and waiting on a review from @ewdurbin at least (although we've chatted about it and I don't think there's much else to do here).

@di di force-pushed the external-classifiers branch from 5f7730d to 128b622 Compare April 3, 2020 02:10
@di di force-pushed the external-classifiers branch from 128b622 to 672ad9a Compare April 3, 2020 02:37
@ewdurbin
Copy link
Member

ewdurbin commented Apr 3, 2020

Just out of an abundance of caution, I'm gonna snag a backup of the classifiers table before this merges. :-D

Otherwise, 💯

@ewdurbin
Copy link
Member

ewdurbin commented Apr 3, 2020

Backup taken!

@di di merged commit 8db5ef0 into master Apr 3, 2020
@di di deleted the external-classifiers branch April 3, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants