-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code comment re: base64-encoded code in virtualenv.py #286
Comments
I see now that the original sources are in the directory named virtualenv_embedded, though this can be mentioned. |
I think the code comment should also include instructions on how to update the base-64 encoded strings in |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions. |
Keep open. |
We indeed should document this, one should use the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions. |
This is becoming obsolete with #1366 now in full swing. |
I think it would help to add a code comment near here explaining why virtualenv.py includes base-64 encoded Python scripts, and where the sources for the scripts come from (e.g. are the human-readable versions stored or copied from elsewhere or are these the sources).
I came across this issue while troubleshooting issue #281. The decoded version of DISTRIBUTE_SETUP_PY was being passed as the command-line argument to a subprocess call that wasn't behaving as expected. The script being base-64 encoded makes the issue harder to debug and troubleshoot (and in particular, modify).
The text was updated successfully, but these errors were encountered: