Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code comment re: base64-encoded code in virtualenv.py #286

Closed
cjerdonek opened this issue Jun 1, 2012 · 7 comments
Closed

Add code comment re: base64-encoded code in virtualenv.py #286

cjerdonek opened this issue Jun 1, 2012 · 7 comments

Comments

@cjerdonek
Copy link
Member

I think it would help to add a code comment near here explaining why virtualenv.py includes base-64 encoded Python scripts, and where the sources for the scripts come from (e.g. are the human-readable versions stored or copied from elsewhere or are these the sources).

I came across this issue while troubleshooting issue #281. The decoded version of DISTRIBUTE_SETUP_PY was being passed as the command-line argument to a subprocess call that wasn't behaving as expected. The script being base-64 encoded makes the issue harder to debug and troubleshoot (and in particular, modify).

@cjerdonek
Copy link
Member Author

I see now that the original sources are in the directory named virtualenv_embedded, though this can be mentioned.

@cjerdonek
Copy link
Member Author

I think the code comment should also include instructions on how to update the base-64 encoded strings in virtualenv.py from the source files located in the virtualenv_embedded directory. In particular, does the source tree have a helper script to do this for you automatically, or is this a manual step?

@dstufft dstufft mentioned this issue Jan 5, 2015
5 tasks
@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions.

@cjerdonek
Copy link
Member Author

Keep open.

@gaborbernat
Copy link
Contributor

We indeed should document this, one should use the embed tox target (we now break the CI if someone forgets to do this).

@stale
Copy link

stale bot commented Apr 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 15, 2019
@gaborbernat
Copy link
Contributor

This is becoming obsolete with #1366 now in full swing.

@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants