Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated importlib-metadata constraint #1953

Merged

Conversation

UsamaSadiq
Copy link
Contributor

@UsamaSadiq UsamaSadiq commented Sep 29, 2020

On Python<3.8, importlib-metadata==2.0.0 causes dependency conflicts because of the pinned constraint python<3.8. There is no breaking change in the importlib-metadata version 2.0.0.

development documentation

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@UsamaSadiq UsamaSadiq force-pushed the update-importlib-metadata-constraint branch from 4d49806 to 6a8c3d1 Compare September 29, 2020 20:24
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #1953 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   93.93%   93.91%   -0.03%     
==========================================
  Files          86       86              
  Lines        4237     4237              
==========================================
- Hits         3980     3979       -1     
- Misses        257      258       +1     
Flag Coverage Δ
#tests 93.91% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292e3a7...45bc97b. Read the comment docs.

@UsamaSadiq UsamaSadiq marked this pull request as ready for review September 29, 2020 20:50
@UsamaSadiq
Copy link
Contributor Author

@gaborbernat test failures are not related to my change. Could you take a look at it? Thanks.

@gaborbernat
Copy link
Contributor

@gaborbernat test failures are not related to my change. Could you take a look at it? Thanks.

Not at the moment. And until tests pass we won't merge. If you can take a look that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants