.gitignore added to places it should not

[stefanholek]

Refs #1806

Virtualenv now drops a .gitignore file. While I understand where you are coming from, it is a mistake to assume virtualenv owns the target directory. For example, I and many people I work with typically do this:

git clone [email protected]:stefanholek/foo
cd foo
virtualenv .
./bin/pip install -e .
./bin/python -m unittest

Recent versions of virtualenv add a .gitignore file into my sandbox. To make matters worse it even overwrites an existing .gitignore file! This is very clearly wrong.

I suggest to not write the .gitignore file unless virtualenv has created the target directory, or at least don't write it if the target directory already contains a .git directory and/or a .gitignore file.

Thanks!

[gaborbernat]

don't write it if the target directory already contains a .git directory and/or a .gitignore file.

I think this makes sense as an improvement.

[gaborbernat]

This now has been released under https://virtualenv.pypa.io/en/20.0.24/changelog.html#v20-0-24-2020-06-22