-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression] When there's setup.cfg
with attr:
in CWD, pip install
crashes under virtualenv 20+
#1685
Comments
Isn't that what it should do? What should happen here in your expectation? |
It doesn't try to import things under Python 3 / Python 2 + virtualenv 16. But under Python 2 + virtualenv 20 it explodes. |
And no, it shouldn't explode when you're installing other packages just because you have something in CWD. |
@webknjaz are you 100% that it does not import on old virtualenv? (maybe it just fails on 20+) - it's a setuptools internal implementation detail |
Positive. It fails on virtualenv 20+ but only combined with Python 2, that's what I'm saying. |
#1688 will likely fix it, can you check? |
Okay, I'll check. |
Confirmed. PR #1688 fixes it: |
Thanks, will merge that today, and cut a release. |
Hello, a fix for this issue has been released via virtualenv 20.0.8; see https://pypi.org/project/virtualenv/20.0.8/ (https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-8-2020-03-04). Please give a try and report back if your issue has not been addressed; if not, please comment here, and we'll reopen the ticket. We want to apologize for the inconvenience this has caused you and say thanks for having patience while we resolve the unexpected bugs with this new major release. |
Thank you @gaborbernat for the responsive fix and stealth release! Your work is much appreciated! |
Issue
$sbj. Possibly related to #1670.
Reproducible under Python 2 specifically, doesn't seem to affect py3.
Repro
setup.cfg
in CWDtest-venv-py2/bin/pip install setuptools
(not necessarily setuptools, could be pip, six, anything really, but has to exist on PyPI)
import boom.versiontools.get_self_version
:Environment
OS: Gentoo Linux (also reproducible under
centos:7
docker container)pip list
of the host python wherevirtualenv
is installed:Output of the virtual environment creation
Make sure to run the creation with
-vvv --with-traceback
:$ python2 -m virtualenv -vvv --with-traceback test-venv-py2
Ref: ansible/ansible-lint#683
The text was updated successfully, but these errors were encountered: