Fix some code quality issues (#466)

Author: pnijhara

.deepsource.toml

@@ -0,0 +1,14 @@
+version = 1
+
+test_patterns = ["tests/**"]
+
+[[analyzers]]
+name = "python"
+enabled = true
+
+  [analyzers.meta]
+  runtime_version = "3.x.x"
+
+[[transformers]]
+name = "black"
+enabled = true

MANIFEST.in

@@ -1,7 +1,7 @@
 graft src
 include *.md pipx_demo.gif logo.png LICENSE
 
-exclude .isort.cfg .pre-commit-config.yaml get-pipx.py makefile generate_docs.py .flake8 mkdocs.yml noxfile.py .coveragerc
+exclude .isort.cfg .pre-commit-config.yaml get-pipx.py makefile generate_docs.py .flake8 mkdocs.yml noxfile.py .coveragerc .deepsource.toml
 prune templates
 prune tests
 prune docs

scripts/migrate_pipsi_to_pipx.py

@@ -13,17 +13,17 @@
 
 def main():
     if not which("pipx"):
-        exit("pipx must be installed to migrate from pipsi to pipx")
+        sys.exit("pipx must be installed to migrate from pipsi to pipx")
 
     if not sys.stdout.isatty():
-        exit("Must be run from a terminal, not a script")
+        sys.exit("Must be run from a terminal, not a script")
 
     pipsi_home = os.environ.get("PIPSI_HOME", os.path.expanduser("~/.local/venvs/"))
     packages = [p.name for p in Path(pipsi_home).iterdir()]
 
     if not packages:
         print("No packages installed with pipsi")
-        exit(0)
+        sys.exit(0)
 
     print("Attempting to migrate the following packages from pipsi to pipx:")
     for package in packages:
@@ -34,7 +34,7 @@ def main():
         answer = input("Continue? [y/n] ")
 
     if answer == "n":
-        exit(0)
+        sys.exit(0)
 
     error = False
     for package in packages:

src/pipx/commands/common.py

@@ -160,7 +160,7 @@ def get_package_summary(
     )
     exposed_binary_names = sorted(p.name for p in exposed_app_paths)
     unavailable_binary_names = sorted(
-        set(add_suffix(name, suffix) for name in package_metadata.apps)
+        {add_suffix(name, suffix) for name in package_metadata.apps}
         - set(exposed_binary_names)
     )
     # The following is to satisfy mypy that python_version is str and not
@@ -293,7 +293,7 @@ def run_post_install_actions(
         if venv.safe_to_remove():
             venv.remove_venv()
 
-        if len(package_metadata.app_paths_of_dependencies.keys()):
+        if package_metadata.app_paths_of_dependencies:
             raise PipxError(
                 f"No apps associated with package {package}. "
                 "Try again with '--include-deps' to include apps of dependent packages, "