From 8f96c41395b7cd868f4208500510b966ae0ae911 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Sun, 28 Jan 2024 06:51:19 -0500 Subject: [PATCH 1/2] Only editable entry should trigger editable installs --- pipenv/utils/dependencies.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pipenv/utils/dependencies.py b/pipenv/utils/dependencies.py index 10cae818b0..868ea5a4eb 100644 --- a/pipenv/utils/dependencies.py +++ b/pipenv/utils/dependencies.py @@ -1207,9 +1207,7 @@ def is_required_version(version, specified_version): def is_editable(pipfile_entry): if hasattr(pipfile_entry, "get"): - return pipfile_entry.get("editable", False) or any( - pipfile_entry.get(key) for key in ("file", "path") + VCS_LIST - ) + return pipfile_entry.get("editable", False) return False From b7d5773cbbdd9f52d4d0012eebe78d0785099a2c Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Thu, 1 Feb 2024 04:29:51 -0500 Subject: [PATCH 2/2] add news fragment --- news/6069.bugfix.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/6069.bugfix.rst diff --git a/news/6069.bugfix.rst b/news/6069.bugfix.rst new file mode 100644 index 0000000000..2d3682e5f9 --- /dev/null +++ b/news/6069.bugfix.rst @@ -0,0 +1 @@ +Adjusted logic which assumed any file, path or VCS install should be considered editable. Instead relies on the user specified editable flag to mark requirement as editable install.